Fix memory leak when passing mapped stores as component props - #5711
Merged
Conversation
Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jkelleyrtp
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the unbounded memory growth in #5671.
Store-typed props (
Store/ReadStore/WriteStore) getauto_into = truein the props macro, so a mapped store (e.g. an item fromstore.iter()) passed as aStore<T>prop is converted viaFrom<MappedStore> for WriteStore, which boxes the lens withWriteSignal::new_maybe_sync→CopyValue::new_maybe_sync. Because store types were missing fromchild_owned_type, that conversion ran in the parent scope's owner: sinceCopyValuehas noDrop, each rerender of the parent leaked one boxed lens per store prop until the parent scope was dropped. In the issue's repro (100 items rerendered on every pointermove), that's ~17 KB leaked per render.The fix adds
looks_like_store_typetochild_owned_type, so store prop conversions run insidewith_owner(props.owner, …)— the same mechanism already used forReadSignal/WriteSignal/callback props — and the boxed lens is freed when the props are dropped.Verified with a counting-allocator harness running the issue's example for 1000 rerenders: heap delta goes from ~17 MB (growing linearly) to flat.
Note: store props still don't participate in the
point_to/mark_dirtymemoization thatsignal_fieldsget inmemoize_impl; that's a separate (non-leaking) issue.Fixes #5671
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/671e48ef36ad4dde9bf93eafa654c32c
Requested by: @ealmloff
Devin Review