Skip to content

Commit 5925be2

Browse files
committed
ENG-1478: fix legacy adapter child.uid → child.text, fix settingKeys on personal panels
1 parent eea529a commit 5925be2

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

apps/roam/src/components/settings/LeftSidebarPersonalSettings.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ const SectionItem = memo(
512512
<PersonalTextPanel
513513
title="Alias"
514514
description="Display name for this item"
515-
settingKeys={["Left sidebar"]}
515+
settingKeys={[]}
516516
initialValue={child.alias?.value ?? ""}
517517
order={0}
518518
uid={child.alias?.uid}
@@ -797,7 +797,7 @@ const LeftSidebarPersonalSectionsContent = ({
797797
<PersonalNumberPanel
798798
title="Truncate-result?"
799799
description="Maximum characters to display"
800-
settingKeys={["Left sidebar"]}
800+
settingKeys={[]}
801801
initialValue={
802802
activeDialogSection.settings.truncateResult?.value ?? 75
803803
}

apps/roam/src/components/settings/utils/accessors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ const getLegacyPersonalLeftSidebarSetting = (): unknown[] => {
198198
return settings.leftSidebar.personal.sections.map((section) => ({
199199
name: section.text,
200200
Children: (section.children || []).map((child) => ({
201-
uid: child.uid,
201+
uid: child.text,
202202
Alias: child.alias?.value || "",
203203
})),
204204
Settings: {

0 commit comments

Comments
 (0)