fix(deploy): label merged/raw mods and name the merged artifact in deploy output (#255)

[dyoung522]

Fixes #255 — implements the issue's decided option (b) exactly: classify before the loop, correct in the footer.

What changed

Core (internal/core):

• DeployProgress.ModClass (DeployModClass: individual / merged / raw), set on DeployDeployed. Classification runs before the deploy loop via enabledMergeSources — the stored fingerprint is deliberately not consulted (wrong on first deploy).
• New DeployMergeSynced phase, emitted once after a successful syncMergedPak when a merged artifact exists: Total = participant count, Detail = artifact name via source.MergeCompiler.MergedArtifactName() (no format literals in core, per Move Unreal/pak knowledge out of core and behind the MergeCompiler seam (before a second DeployCompile game exists) #256), RawFallbacks = participants that fell back to raw.
• DeployResult gains MergedArtifact/MergedMods/RawFallbacks so progress-less callers (the TUI) get the same readout.

CLI (cmd/lmm/deploy.go):

Deploying 3 mod(s) — compile mode...

  ✓ Bear Mount (merged)
  ✓ Raw Pak Mod (raw)
  ✓ Loose Mod

Merged 1 mod(s) → zzz_LMM_Merged_P.pak
Deployed: 3

The optimistic case — a pak labeled (merged) whose conversion then fails — is corrected by the existing pak conversion failed … deploying raw warning plus the footer's (N deployed raw) count. Deployed: N still counts merge participants. The Warnings/Notes ↔ event invariant at cmd/lmm/deploy.go is untouched (the merge event is not a warning; nothing double-prints).

TUI (internal/tui/service_core.go): Deployed 1 mod(s) — merged 1 → zzz_LMM_Merged_P.pak in the one-row outcome Message, built from the new DeployResult fields. Deliberately not routed through Warnings (#253's overlay auto-opens on 2+ warnings).

Guarantees held

• Non-compile output byte-identical — every pre-existing deploy test passes untouched; a new gating test additionally pins no compile text leaks into non-compile output.
• Acceptance greps clean — grep -n '"[^"]*\.pak"' and grep -in exmodz over non-test internal/core match comments only.
• TDD: all new tests written first and shown failing (core: new symbols undefined; CLI/TUI: today's lying output captured verbatim in the failure diff).

Coverage added

• Core: three-way classification + merge event ordering/counts, conversion-failure fallback counts, non-compile no-readout gating.
• CLI: labels + footer happy path, conversion-failure correction end to end (combined stdout/stderr), non-compile gating.
• TUI: compile-game message readout + empty-warnings assertion.

Out of scope

• TUI: Deploy is the only mutation with no live progress (stale "5b streams events" comment) #257 (TUI live deploy progress) untouched — when picked up, its stream can reuse DeployMergeSynced as-is.

Verification

go build ./... && go vet ./... && gofmt -l . && go test ./... — all clean; trunk check on changed files: no new issues. Manual TUI smoke test pending (merge gate, coordinator's step).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR implements issue #255’s “option (b)” deploy readout for compile-mode games by pre-classifying mods before the deploy loop, labeling per-mod output accordingly, and emitting a post-sync merged-artifact footer (plus result fields for progress-less callers like the TUI).

Changes:

• Add compile-mode deploy classification (DeployModClass) and a one-shot post-sync phase (DeployMergeSynced), plus DeployResult fields to carry merged artifact/counts.
• Update CLI deploy output to (a) drop the misleading using <method> header on compile games, (b) label per-mod lines as (merged) / (raw), and (c) print a merged-artifact footer above the summary.
• Update TUI deploy outcome message to include merged-artifact readout based on DeployResult (since TUI deploy currently has no progress stream), and add targeted test coverage.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/tui/service_core.go	Extends the one-row deploy outcome message to include merged artifact + counts when present.
internal/tui/service_core_deploy_compile_test.go	Adds a TUI parity test asserting the merged artifact is named in the deploy message (and not routed through warnings).
internal/core/merged_pak.go	Adds pre-loop compile deploy classification and post-sync merge outcome recording onto DeployResult + progress.
internal/core/flows.go	Introduces DeployMergeSynced, DeployModClass, and new fields on DeployProgress/DeployResult; wires classification + merge outcome into DeployProfile.
internal/core/flows_deploy_compile_readout_test.go	Adds core-level tests for 3-way classification, merge event ordering, raw-fallback reporting, and non-compile gating.
cmd/lmm/deploy.go	Adjusts CLI output for compile mode (header, per-mod labels, merged footer placement) while preserving non-compile output.
cmd/lmm/deploy_compile_test.go	Adds CLI compile-mode tests for labels/footer and conversion-failure correction behavior.
CHANGELOG.md	Documents the corrected compile-mode deploy readout behavior for CLI + TUI (#255).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dyoung522]

Confirmed — the comment overstated it: core sets Total to the mods the merged artifact actually carries (raw fallbacks are excluded and ride RawFallbacks). Reworded in 98fe168.

[dyoung522]

Confirmed mismatch. Kept the best-effort partial-map behavior deliberately (the readout must never fail or degrade the deploy; a partial map only loses labels for later mods in an already-degenerate corner: --all with a disabled retained mod and no compile source configured) and rewrote the doc comment to state that contract honestly in 98fe168.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.