Say whether a country has been chosen - #2102
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
A poll can be held open only to certain countries, and the countries are picked from a list where each one is drawn with a tick beside it. The tick is the whole of what says whether that country is among the ones taken. None of it reached a screen reader. A country read the same whether it had been taken or left, and a press on one said nothing of which of the two it had just done, so what the poll would end up open to could not be known at all. Give a country the kind of a check box and the state of one, so the tick is spoken as state in the words of the screen reader and a press on a country is answered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A poll can be held open only to certain countries, and the countries are picked from a list where each one is drawn with a tick beside it. The tick is the whole of what says whether that country is among the ones taken.
None of it reached a screen reader. A country read the same whether it had been taken or left, and a press on one said nothing of which of the two it had just done, so what the poll would end up open to could not be known at all.
Give a country the kind of a check box and the state of one, so the tick is spoken as state in the words of the screen reader and a press on a country is answered.
Checking it
With TalkBack on, start a poll, turn on holding it open to certain countries, and open the list of them. Swipe through the countries and press some of them.
Before, every country read the same whether it had been taken or left, and a press said nothing at all, so there was no way of knowing what the poll was open to. Now each country reads as a check box with its state, and a press is answered by the state being said again.
The same list is used for choosing the countries of a giveaway, which reads the same way now.