feat(mountstats): 新增proc挂载导出接口实现#1832
Merged
Merged
Conversation
xboHodx
commented
Apr 3, 2026
xboHodx
commented
Contributor
- 实现/proc/[pid]/mounts、/proc/[pid]/mountinfo、/proc/[pid]/mountstats接口
- 新增mount_view模块统一处理挂载视图渲染逻辑
- 支持按目标进程视角导出挂载信息
- 文档添加procfs相关章节
…ng and validation - Deleted init_skill.py as it was redundant. - Updated package_skill.py to exclude unnecessary files and directories during packaging. - Enhanced quick_validate.py to include compatibility field validation and improved error messages. - Added run_eval.py to evaluate skill descriptions against queries and output results in JSON format. - Introduced run_loop.py to facilitate an iterative evaluation and improvement process for skill descriptions. - Created utils.py for shared utility functions, including SKILL.md parsing. Signed-off-by: xboHodx <xbohodx2024@gmail.com>
- 实现/proc/[pid]/mounts、/proc/[pid]/mountinfo、/proc/[pid]/mountstats接口 - 新增mount_view模块统一处理挂载视图渲染逻辑 - 支持按目标进程视角导出挂载信息 - 文档添加procfs相关章节 Signed-off-by: xboHodx <xbohodx2024@gmail.com>
github-actions
Bot
added
the
ambiguous
xboHodx
changed the title
github-actions
Bot
added
enhancement
Member
|
skill creator应该不要提交到dragonos吧？ |
… packaging and validation" This reverts commit 250dc9b.
Contributor
Author
这是 #1823 的skill，不小心交上去了。现在撤下来应该没问题了。 |
…tats Signed-off-by: xboHodx <xbohodx2024@gmail.com>
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a6e4c94bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: xboHodx <xbohodx2024@gmail.com>
Integrate ProcPidTarget-based procfs (DragonOS-Community#1893) with mount_view mountstats support. Resolve conflicts by keeping mount rendering in mount_view while adopting master's pid namespace target resolution and FileOps open API. Co-authored-by: Cursor <cursoragent@cursor.com>
- Updated `/proc/mounts`, `/proc/[pid]/mounts`, and related files to improve rendering and caching behavior. - Refactored mount entry collection and rendering functions for better clarity and performance. - Adjusted permissions in `MountStatsFileOps` to allow read access for group users. - Introduced new test suite `proc_mount_exports` to validate mount information consistency across different procfs entries. - Added entries to `.gitignore` for markdown files and cursor files.
fslongjin
requested changes
May 30, 2026
Member
|
@codex 从架构、linux语义等角度审查代码。 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f733b8b568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fslongjin
force-pushed
the
feat/mountstats
branch
from
073a889 to
48f5305
Compare
Signed-off-by: longjin <longjin@dragonos.org>
fslongjin
force-pushed
the
feat/mountstats
branch
from
48f5305 to
f302f8c
Compare
- Removed the deprecated `mount_view` and `mounts` files, centralizing mount-related functionality into a new `mount` module. - Updated references in the `procfs` root and other related files to utilize the new structure. - Introduced new helper functions for rendering and collecting mount information, improving code organization and maintainability. - Added symlink support for `/proc/mounts` pointing to `self/mounts`. This refactor enhances clarity and performance in handling mount information within the proc filesystem.
Keep procfs/mount module layout and symlink /proc/mounts; integrate remote docs, TCP bind fix, and extended proc_mount_exports tests. Co-authored-by: Cursor <cursoragent@cursor.com>
…ts documentation - Deleted the `mount_exports_review_plan.md` file as it is no longer needed. - Revised the `mounts.md` documentation to clarify the procfs mount export interfaces, including detailed descriptions of `/proc/mounts`, `/proc/[pid]/mounts`, `/proc/[pid]/mountinfo`, and `/proc/[pid]/mountstats`. - Enhanced the structure and readability of the documentation, ensuring it aligns with the current implementation and usage scenarios. This update improves the clarity of the procfs mount interfaces and removes outdated content.
- Updated the inode mode handling in `pid_mount.rs` to ensure that `/proc/[pid]/mountstats` is owner-readable only, while other mount-related files remain world-readable. - This change aligns with Linux's permissions model for procfs mount information, enhancing security and consistency. This update improves the clarity of permission settings for procfs mount files.
fslongjin
reviewed
Jun 2, 2026
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ac113427f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: longjin <longjin@dragonos.org>
fslongjin
approved these changes
Jun 2, 2026
fslongjin
added a commit
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.