fix the device owner ship model - #15
Merged
Merged
Conversation
bpapaspyros
reviewed
Aug 24, 2026
bpapaspyros
left a comment
Contributor
There was a problem hiding this comment.
overall looking good, just trying to wrap my head around the threading parts.
Also, does keeping all devices in one vector and then mutex locking creating a bottleneck in some places? perhaps it's insignificant even. (I'm re-reading, but I wanted to already post the syntactic/code comments that came to mind)
Co-authored-by: Vaios Papaspyros <8146703+bpapaspyros@users.noreply.github.com>
Co-authored-by: Vaios Papaspyros <8146703+bpapaspyros@users.noreply.github.com>
bpapaspyros
approved these changes
Aug 24, 2026
bpapaspyros
left a comment
Contributor
There was a problem hiding this comment.
looks good then, thanks for the explanations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
This PR changes the device owner ship model to a more sane approach. In the same step the
GenericEthercatDeviceand theEthercatDeviceBasewere fused into a singleEthercatDeviceclass.Example how this affects the downstream users
Why