EVA-4231 - Add error handling for missing validation outputs - #173
Merged
Conversation
apriltuesday
left a comment
apriltuesday
left a comment
Contributor
There was a problem hiding this comment.
I think it's also worth updating any eva-sub-cli results files used in eva-submission tests, e.g. here -- I don't think the result_status value is actually used by eva-submission but it would be good to be sure. Presumably the integration tests will also show if there are any issues.
Co-authored-by: April Shen <april.tuesday@gmail.com>
… some files missing some present (report dummy validation errors) Split the VCF and assembly check validation report
apriltuesday
approved these changes
Aug 3, 2026
apriltuesday
left a comment
apriltuesday
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Just a tiny nitpick for the report format but otherwise all looks good to me.
Co-authored-by: April Shen <april.tuesday@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.