refactor: circular buffer - #741
Open
janishorsts wants to merge 3 commits into
Open
Conversation
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
gilescope
approved these changes
Aug 1, 2026
gilescope
left a comment
There was a problem hiding this comment.
Approved. Surprised there's not a fairly standard dep that does this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Benefits, Issues Resolved & DX Impact
circbuffromutil/tointernal/circbufto encapsulate internal circular buffer implementation details used bylogbus.Command(which maintains a bounded 80 KB tail log buffer for command output). AddedErrInvalidSizesentinel error, fast-path write handling for incoming data larger than capacity, defensive cloning onBytes(), and zero-value safety.Bytes(), eliminated silent failures on non-positive buffer capacities with explicit error signaling.t.Parallel()), added explicit immutability and zero-value safety test cases, and included write throughput benchmarks.⚡ Performance Impact
12.4 ns/op4.68 ns/op-62.2%0 B/op0 B/op0.0%0 allocs/op0 allocs/op0.0%📦 Binary Size Impact
42.10 MB/42.10 MB/0.00 KB(0.0%)