Skip to content

refactor: remove ~nelsam packages - #745

Open
janishorsts wants to merge 1 commit into
mainfrom
refactor-remove-nelsam
Open

refactor: remove ~nelsam packages#745
janishorsts wants to merge 1 commit into
mainfrom
refactor-remove-nelsam

Conversation

@janishorsts

Copy link
Copy Markdown
Collaborator

Mock generators like helheim add significant noise, fragile channel-based synchronization, and unnecessary third-party dependencies to test packages. Hand-written fakes that satisfy minimal interfaces are clearer, faster, and much easier to read and debug.
This change removes git.sr.ht/~nelsam/hel and github.com/nelsam/correct along with all generated mock code.

Changes

  • Removed generated mocks: Deleted helheim_mocks_test.go and associated generation helpers in util/proj and util/llbutil/authprovider.
  • Simplified test suites: Replaced mock expectations (pers.MethodWasCalled, complex channel assertions) in multiauthprovider_test.go, podman_test.go, and golang_test.go with minimal, explicit test fakes (such as fakeFS, fakeExecer, fakeChild).
  • Table-driven tests: Refactored golang_test.go into clean, table-driven test cases.
  • Dependency cleanup: Dropped git.sr.ht/~nelsam/hel and github.com/nelsam/correct from go.mod and go.sum, as well as mock-generation build targets in Earthfile.

@janishorsts janishorsts self-assigned this Jul 31, 2026
@janishorsts
janishorsts requested a review from a team as a code owner July 31, 2026 08:26
@janishorsts
janishorsts requested review from kmannislands and removed request for a team July 31, 2026 08:26
@janishorsts janishorsts added the ai-assisted Authored with AI assistance label Jul 31, 2026
@github-actions

Copy link
Copy Markdown

🎉 Are we earthbuild yet?

Great progress! You've reduced "earthly" occurrences by 1 (0.02%)

📈 Overall Progress

Branch Total Count
main 4752
This PR 4751
Difference -1 (0.02%)

📁 Changes by file type:

File Type Change
Go files (.go) ➖ No change
Documentation (.md) ➖ No change
Earthfiles ✅ -1

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@janishorsts janishorsts changed the title refactor: remove nelsam/hel & nelsam/correct refactor: remove ~nelsam packages Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Authored with AI assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant