WebExtension stage1 support (backporting it from Firefox 55)#23
Open
OwnedByWuigi wants to merge 5 commits into
Open
WebExtension stage1 support (backporting it from Firefox 55)#23OwnedByWuigi wants to merge 5 commits into
OwnedByWuigi wants to merge 5 commits into
Conversation
…s flat out false.
This reverts commit 8049053.
|
Are you sure this is only WebExtensions? This is way more code than I needed to port over WebExtension support from your fork |
Member
Author
Yes I’m sure it’s only WebExtensions. Ported it from FF55 instead of Dactyloidae for extended support that I’m too lazy to implement myself if I’m being honest |
Member
Author
|
Do not merge this yet. I've still got some minor bugs to sort out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It compiles on Windows, that's all I have to say.