Skip to content

Remove duplicate Jenkins push trigger - #6166

Merged
j0ntz merged 2 commits into
developfrom
codex/remove-duplicate-jenkins-trigger
Sep 4, 2026
Merged

Remove duplicate Jenkins push trigger#6166
j0ntz merged 2 commits into
developfrom
codex/remove-duplicate-jenkins-trigger

Conversation

@JP0P

@JP0P JP0P commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the redundant Declarative Pipeline githubPush() trigger from the
Edge React GUI multibranch Jenkinsfile.

GitHub Branch Source remains responsible for normal branch-update delivery.

Why

The multibranch job already schedules builds from Branch Source events. The
additional githubPush() handler could inspect multiple branches for the same
repository event and schedule a revision that was already building.

This produced extra same-revision builds both for isolated updates and when
another branch was updated while the first remained active.

Live validation results

Validation ran in the live EdgeApp/edge-react-gui multibranch job using the
dedicated test-parm and test-colby branches.

Controlled scenario Before change After change
Isolated Parm update Extra Parm build in 4/5 trials Extra Parm build in 0/5 trials
Colby updated while Parm remained active Extra Parm build in 10/10 trials Extra Parm build in 0/10 trials
Colby's own update in the overlap series Extra Colby build in 5/10 trials Extra Colby build in 0/10 trials

Across all 15 post-change trials:

  • All 15 Parm updates produced exactly one Parm build.
  • All 10 Colby updates produced exactly one Colby build.
  • All 25 expected builds completed successfully.
  • No extra same-revision build occurred.

Method and controls

  • The production change removes only the three-line githubPush() block.
  • The before/after validation trees differed only by that block and its adjacent
    blank line.
  • A frozen checkout-and-delay pipeline provided a consistent observation window
    without running the application build.
  • Every retained overlap was classified after completion using archived Branch
    Source, queue-entry, and build-completion timestamps.
  • Attempts where an extra request preceded the Colby event were excluded and
    replaced, preserving ten verified overlap trials.
  • Each measured window contained only the planned branch updates.
  • An independent consistency review confirmed revisions, timing, build causes,
    configuration state, and trial totals.

Risk

The change affects build scheduling only; it does not modify application code.

The main risk was that removing the explicit trigger might prevent expected
builds. The live results directly checked this: every one of the 25 expected
branch builds was delivered and completed successfully through Branch Source.

The findings are scoped to the scheduling paths exercised in these controlled
Edge React GUI trials.

Evidence

The report links the Jenkins builds directly. A verified SHA-256 manifest
covers all 627 retained evidence files. The raw archive and manifest are
available on request.


Note

Low Risk
CI scheduling-only change with no application code touched; live validation showed expected builds still fire via Branch Source after removing the duplicate trigger.

Overview
Removes the redundant triggers { githubPush() } block from the multibranch Jenkinsfile, so branch builds are scheduled only through GitHub Branch Source instead of a second push handler that could queue duplicate same-revision builds (including when another branch was updating while a build was already running).

Adds docs/JENKINS_TRIGGER_VALIDATION.md and docs/JENKINS_TRIGGER_VALIDATION_TRIALS.csv, documenting live before/after trials on dedicated Jenkins branches: extra duplicate Parm/Colby builds dropped to zero while all expected post-change builds still completed successfully.

Reviewed by Cursor Bugbot for commit 33074a5. Bugbot is set up for automated code reviews on this repo. Configure here.

@JP0P
JP0P marked this pull request as draft August 19, 2026 02:27
@JP0P
JP0P force-pushed the codex/remove-duplicate-jenkins-trigger branch from b7f1ba3 to 5cc6634 Compare August 19, 2026 21:07
@JP0P
JP0P marked this pull request as ready for review August 19, 2026 21:07
@j0ntz
j0ntz force-pushed the codex/remove-duplicate-jenkins-trigger branch from 5cc6634 to 6e300f6 Compare September 4, 2026 22:21
@j0ntz
j0ntz enabled auto-merge September 4, 2026 22:22
@j0ntz
j0ntz merged commit 41eb93b into develop Sep 4, 2026
7 checks passed
@j0ntz
j0ntz deleted the codex/remove-duplicate-jenkins-trigger branch September 4, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants