Skip to content

[Ready for Review] A basic API#652

Open
bloxgate wants to merge 16 commits into
Electrical-Age:developfrom
bloxgate:api
Open

[Ready for Review] A basic API#652
bloxgate wants to merge 16 commits into
Electrical-Age:developfrom
bloxgate:api

Conversation

@bloxgate

@bloxgate bloxgate commented Feb 13, 2017

Copy link
Copy Markdown
Member

@Baughn suggested I start a PR for this to get some feedback. At the moment this is a very basic API to allow the manipulation of recipes and fuels by other mods.

This uses a lot of reflection, and a bit of shuffling of some of the existing internal API-like stuff to try and make sure that there won't be any crashes if someone bundles and calls this without ELN loaded.

  • Machine recipe manipulation
  • Fuel list modification
  • Allow modifying fuel lists at runtime
  • Minetweaker
    Allow other mods to use the API to connect components to the grid. I've been told this is being done as part of the 1.10 port now.

This change is Reviewable

@AMIDIBOSS

Copy link
Copy Markdown
Contributor

I'll definitly use your api in my mod 😆

@bloxgate bloxgate changed the title [DNM] [WIP] A basic API A basic API Sep 4, 2017
@bloxgate

bloxgate commented Sep 4, 2017

Copy link
Copy Markdown
Member Author

Currently doing some testing with @DonBruce64 via Gitter. If everything works out there, this should be good for a merge.

@AMIDIBOSS

Copy link
Copy Markdown
Contributor

Well... I'm still waiting...

@bloxgate bloxgate changed the title A basic API [Ready for Review] A basic API Sep 4, 2017
@Baughn

Baughn commented Oct 14, 2017

Copy link
Copy Markdown
Contributor

Could you merge the current develop branch into this, before I review?

@Baughn Baughn self-assigned this Oct 14, 2017
@bloxgate bloxgate force-pushed the api branch 2 times, most recently from 550aa60 to 4b0e42f Compare January 9, 2018 17:18
@bloxgate

bloxgate commented Jan 9, 2018

Copy link
Copy Markdown
Member Author

EDIT: Something went way weird. Squash merge is probably needed for this. Sorry... no idea what I did wrong with that rebase Fixed.

Just rebased this onto develop again. Haven't had a chance to make sure its still good, but there are some merge conflicts now as well.

@Baughn

Baughn commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

Oh dear, it's been a while.

We're pretty close to a functioning 1.10 port by this point, or at least a compiling one. That's the ideal time to change / add APIs, so I'll look at this once we get there. It should just be a few days now.

@bloxgate

bloxgate commented Feb 5, 2019

Copy link
Copy Markdown
Member Author

Great, I'll get this updated again soon. Looks like its gotten out of date again.

@Baughn

Baughn commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

Alas. I promise I won't ignore it again!

bloxgate added a commit to bloxgate/ElectricalAge that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants