fix: Preserve Markdown inline boundary spaces - #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve collapsed whitespace that appears just inside
a,b,strong,em, andielements when serializing to Markdown. This reimplements the behavior reported in #78 against the current Markdown builder.The fix records leading and trailing collapsed whitespace in child builders and feeds it back through the parent builder's ordinary whitespace handling. It also avoids duplicate spaces after heading and list markers.
Inline child builders inherit the active blockquote depth, so formatting and link elements cannot reset the existing bound on deeply nested blockquote prefixes.
User impact
Rich-text HTML such as
<p>This is <b>very </b>important.</p>now serializes asThis is **very** important.instead of joining the surrounding words. Equivalent link and emphasis boundaries behave consistently.Validation
pre-commit run --all-files