Add GitHub Pages deploy - #58
Merged
Merged
Conversation
Keep S3 release deploys on root paths by setting PUBLIC_URL only in the Pages workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd251ed. Configure here.
Official Pages workflows keep cancel-in-progress false so a newer push cannot leave a stuck deployment. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
build/on push tomain(or via manual run).PUBLIC_URLfrom the Pages base path and uses it as the React Router basename so the project site works at/dapp-example.concurrency.cancel-in-progress: falseso a newermainpush cannot abort an in-flight deploy and wedge Pages.Test plan
main)https://emurgo.github.io/dapp-example/and confirm the app loads (JS/CSS/WASM)Note
Low Risk
CI/deploy and routing basename only; existing S3/CloudFront release path is unchanged. Low risk beyond Pages config and SPA 404 fallback.
Overview
Adds GitHub Pages deploy on
main(and manual dispatch) so the CRA app can be hosted at the project-site path.The workflow builds with
PUBLIC_URLfrom the Pages base path, writes a production.env, and prepares SPA files (.nojekyll,404.html).BrowserRouternow uses thatPUBLIC_URLasbasenameso routing works under/dapp-examplewithout changing root-relative S3/CloudFront deploys.Bumps package version to
2.5.0. Pages concurrency does not cancel in-flight deploys.Reviewed by Cursor Bugbot for commit d01f428. Bugbot is set up for automated code reviews on this repo. Configure here.