Skip to content

Add GitHub Pages deploy - #58

Merged
Nebyt merged 3 commits into
mainfrom
chore/github-pages
Aug 24, 2026
Merged

Nebyt merged 3 commits into
mainfrom
chore/github-pages

Conversation

@Nebyt

@Nebyt Nebyt commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a GitHub Pages workflow that builds the CRA app and publishes build/ on push to main (or via manual run).
  • Sets PUBLIC_URL from the Pages base path and uses it as the React Router basename so the project site works at /dapp-example.
  • Leaves the existing S3/CloudFront release deploy on root-relative assets.
  • Keeps Pages concurrency.cancel-in-progress: false so a newer main push cannot abort an in-flight deploy and wedge Pages.

Test plan

  • In the repo: Settings → Pages → Source: GitHub Actions
  • Merge this PR (or run the GitHub Pages workflow on main)
  • Open https://emurgo.github.io/dapp-example/ and confirm the app loads (JS/CSS/WASM)
  • Confirm wallet connect still works over HTTPS
  • Confirm a release still deploys to S3/CloudFront as before

Note

Low Risk
CI/deploy and routing basename only; existing S3/CloudFront release path is unchanged. Low risk beyond Pages config and SPA 404 fallback.

Overview
Adds GitHub Pages deploy on main (and manual dispatch) so the CRA app can be hosted at the project-site path.

The workflow builds with PUBLIC_URL from the Pages base path, writes a production .env, and prepares SPA files (.nojekyll, 404.html). BrowserRouter now uses that PUBLIC_URL as basename so routing works under /dapp-example without changing root-relative S3/CloudFront deploys.

Bumps package version to 2.5.0. Pages concurrency does not cancel in-flight deploys.

Reviewed by Cursor Bugbot for commit d01f428. Bugbot is set up for automated code reviews on this repo. Configure here.

Keep S3 release deploys on root paths by setting PUBLIC_URL only in the Pages workflow.

Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cd251ed. Configure here.

Comment thread .github/workflows/github-pages.yml Outdated
Nebyt and others added 2 commits August 24, 2026 17:42
Official Pages workflows keep cancel-in-progress false so a newer push cannot leave a stuck deployment.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Nebyt
Nebyt merged commit 5ed8689 into main Aug 24, 2026
5 checks passed
@Nebyt
Nebyt deleted the chore/github-pages branch August 24, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant