Avoid stale address status from trimmed cache key - #49
Open
endereco-alex wants to merge 1 commit into
Open
Conversation
generateAddressCacheKey() trimmed every address field before building the cache key, while getAddressMeta() sends the raw, untrimmed values to the API. Whenever the only difference between the user's input and the auto-corrected prediction was leading/trailing whitespace, both requests produced the same cache key. The automatic-correction flow in processAddressCheck() relies on a second getAddressMeta() call to revalidate the corrected address, but that call hit the stale cache entry instead of the API, so "address_needs_correction" was kept alongside "address_selected_automatically" - a contradictory pair for ams_status. Fix: stop trimming values in generateAddressCacheKey() so the cache key matches exactly what is sent to the API. Addresses that differ only by whitespace now get distinct cache entries, so the post-correction revalidation always triggers a real API request and returns the correct, final status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateAddressCacheKey() trimmed every address field before building the cache key, while getAddressMeta() sends the raw, untrimmed values to the API. Whenever the only difference between the user's input and the auto-corrected prediction was leading/trailing whitespace, both requests produced the same cache key.
The automatic-correction flow in processAddressCheck() relies on a second getAddressMeta() call to revalidate the corrected address, but that call hit the stale cache entry instead of the API, so "address_needs_correction" was kept alongside "address_selected_automatically" - a contradictory pair for ams_status.
Fix: stop trimming values in generateAddressCacheKey() so the cache key matches exactly what is sent to the API. Addresses that differ only by whitespace now get distinct cache entries, so the post-correction revalidation always triggers a real API request and returns the correct, final status.