add npv regression test for circularities example#1333
Draft
Aurashk wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 89.51% 89.53% +0.02%
==========================================
Files 58 58
Lines 8537 8555 +18
Branches 8537 8555 +18
==========================================
+ Hits 7642 7660 +18
Misses 580 580
Partials 315 315 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@tsmbland thought you might be the best person to look at this because it looks like you did some work on circularities recently. After merging back on main the new circularities npv model fails to run all the way through. Initially it was able to run with no errors. Not sure if this is expected or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new regression test for the circularities model with the agent objectives all patched with lcox -> npv
Fixes #1246
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks