LLVM: Add if/ifelse, extract IRCoercion, flatten irVariableTableType#1415
Open
LadyCailin wants to merge 1 commit intomasterfrom
Open
LLVM: Add if/ifelse, extract IRCoercion, flatten irVariableTableType#1415LadyCailin wants to merge 1 commit intomasterfrom
LadyCailin wants to merge 1 commit intomasterfrom
Conversation
- Implement if/ifelse control flow for the LLVM backend. ifelse handles the general [cond, code]... pattern; _if delegates to it. Branch bodies push/pop variable scopes matching the intended strict-mode semantics. - Extract coercion helpers (coerceToBoolean, coerceToDouble, emitCoerceToBoolRuntime, emitCoerceToDoubleRuntime) from BasicLogic into a new shared IRCoercion class. Add unified toBool() that handles both compile-time known types and runtime ms_value dispatch. - Flatten irVariableTableType from Stack<Map<Integer, IRType>> to a plain Map, since SSA numbers are function-global and must remain visible after scope pops. MS-level variable scoping stacks are unchanged. - Add IRBuilder.appendLabel() for type-safe label emission, replacing manual string concatenation with ":".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement if/ifelse control flow for the LLVM backend. ifelse handles the general [cond, code]... pattern; _if delegates to it. Branch bodies push/pop variable scopes matching the intended strict-mode semantics.
Extract coercion helpers (coerceToBoolean, coerceToDouble, emitCoerceToBoolRuntime, emitCoerceToDoubleRuntime) from BasicLogic into a new shared IRCoercion class. Add unified toBool() that handles both compile-time known types and runtime ms_value dispatch.
Flatten irVariableTableType from Stack<Map<Integer, IRType>> to a plain Map, since SSA numbers are function-global and must remain visible after scope pops. MS-level variable scoping stacks are unchanged.
Add IRBuilder.appendLabel() for type-safe label emission, replacing manual string concatenation with ":".