修改主页面的启动画面 - #143
Open
YzmmQwQ wants to merge 3 commits into
Open
Conversation
Reviewer's GuideThe PR redesigns the landing page startup experience around a timed SVG geometric-logo animation synchronized with the hero reveal, while removing the former personalization preview feature and all of its supporting UI, localization, asset, and CSS code. Sequence diagram for the timed startup logo animationsequenceDiagram
participant AppVue
participant useWaveLoader
participant LoaderScreen
participant HeroTitle
AppVue->>useWaveLoader: useWaveLoader({ duration: 2600 })
AppVue->>AppVue: onMounted()
AppVue->>AppVue: setTimeout 950ms
AppVue->>LoaderScreen: logoPhase = next
AppVue->>AppVue: setTimeout 1750ms
AppVue->>LoaderScreen: logoPhase = expand
LoaderScreen-->>HeroTitle: loaderLeaving
HeroTitle->>HeroTitle: animation-play-state running
AppVue->>AppVue: onBeforeUnmount()
AppVue->>AppVue: clearTimeout(logoPhaseTimer)
AppVue->>AppVue: clearTimeout(logoExpandTimer)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/landing/src/style.css" line_range="161" />
<code_context>
+ height: 100%;
+ animation: loaderMarkIn 0.75s cubic-bezier(0.16, 1, 0.3, 1) both;
+}
+.loader-mark-svg rect {
+ height: 100px;
+ rx: 50px;
+ transition:
+ x 0.7s cubic-bezier(0.16, 1, 0.3, 1),
+ y 0.7s cubic-bezier(0.16, 1, 0.3, 1),
+ width 0.7s cubic-bezier(0.16, 1, 0.3, 1),
+ height 0.7s cubic-bezier(0.16, 1, 0.3, 1),
+ rx 0.7s cubic-bezier(0.16, 1, 0.3, 1),
+ fill 0.7s ease;
+}
+/* first 布局：白块 + 右上蓝块 + 底部浅色条（600×600 设计稿以中心平移而来） */
+.lm-white { x: calc(50% - 220px); y: calc(50% - 100px); width: 365px; height: 200px; fill: #f8f9fb; }
+.lm-blue { x: calc(50% + 20px); y: calc(50% - 220px); width: 200px; fill: #3477d3; }
+.lm-feeder { x: calc(50% - 260px); y: calc(50% + 160px); width: 520px; fill: #ecf5fb; }
</code_context>
<issue_to_address>
**issue (bug_risk):** The generic `.loader-mark-svg rect` rule has higher specificity than `.lm-white`, so its `height: 100px` overrides `.lm-white`'s declared `height: 200px`; the white logo block renders at half the intended height and the staged logo geometry is incorrect.
**Suggested fix:** Increase the class rule's specificity or move the shared rect defaults before the per-rectangle rules so `.lm-white { height: 200px; }` wins.
```suggestion
.loader-mark-svg .lm-white { x: calc(50% - 220px); y: calc(50% - 100px); width: 365px; height: 200px; fill: #f8f9fb; }
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: docs/landing/src/style.css:161
| fill 0.7s ease; | ||
| } | ||
| /* first 布局：白块 + 右上蓝块 + 底部浅色条（600×600 设计稿以中心平移而来） */ | ||
| .lm-white { x: calc(50% - 220px); y: calc(50% - 100px); width: 365px; height: 200px; fill: #f8f9fb; } |
There was a problem hiding this comment.
issue (bug_risk): The generic .loader-mark-svg rect rule has higher specificity than .lm-white, so its height: 100px overrides .lm-white's declared height: 200px; the white logo block renders at half the intended height and the staged logo geometry is incorrect.
Suggested fix: Increase the class rule's specificity or move the shared rect defaults before the per-rectangle rules so .lm-white { height: 200px; } wins.
Suggested change
| .lm-white { x: calc(50% - 220px); y: calc(50% - 100px); width: 365px; height: 200px; fill: #f8f9fb; } | |
| .loader-mark-svg .lm-white { x: calc(50% - 220px); y: calc(50% - 100px); width: 365px; height: 200px; fill: #f8f9fb; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动内容
修改主页面的启动画面
验证
已验证
截图或录屏
旧的：
修改：
CLA
如果不勾选上面的声明，也可以由 PR 作者在评论区发送：
Summary by Sourcery
Redesign the landing page startup experience around a staged animated logo reveal and streamline the page by removing the personalization preview.
New Features:
Enhancements:
Chores: