feat: Decal spawn, Playgunsound & FakeFire Methods / Firearm Module Propertys#842
Merged
Conversation
MS-crew
changed the title
VALERA771
previously approved these changes
Jun 3, 2026
louis1706
reviewed
Jun 3, 2026
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
MS-crew
marked this pull request as draft
June 3, 2026 19:48
MS-crew
marked this pull request as ready for review
June 3, 2026 19:53
louis1706
requested changes
Jun 4, 2026
louis1706
left a comment
louis1706
left a comment
There was a problem hiding this comment.
Obsolete the previous SpawnDecals that already exist
* refactor: CustomScpTermination * for new cassie update * fix: Remove breaking change --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
Author
|
MS-crew
marked this pull request as draft
June 4, 2026 19:37
MS-crew
marked this pull request as ready for review
June 4, 2026 20:47
This reverts commit a9d58b2.
MS-crew
dismissed stale reviews from louis1706 and VALERA771
June 8, 2026 14:10
The base branch was changed.
VALERA771
requested changes
Jun 8, 2026
VALERA771
left a comment
VALERA771
left a comment
There was a problem hiding this comment.
About names, I'd recommend something like SendFirearmRpc, but still I don't really think that we really need this methods cuz that's a basic Mirror
VALERA771
approved these changes
Jun 9, 2026
louis1706
approved these changes
Jun 13, 2026
Someone-193
reviewed
Jul 1, 2026
Someone-193
reviewed
Jul 1, 2026
Someone-193
reviewed
Jul 1, 2026
Someone-193
approved these changes
Jul 16, 2026
louis1706
added a commit
that referenced
this pull request
Jul 16, 2026
…ropertys (#842) by MS Co-Authored-By: MS <100300664+MS-crew@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
The spawn code was inspired by Dr.Dinspit`s code
https://github.com/icedchai/DarkAndGrittyGunplay/blob/main/DarkAndGrittyGunplay/Features/DecalRpcCache.cs
What is the current behavior? (You can also link to an open issue here)
No Decal Spawn
What is the new behavior? (if this is a feature change)
Yes Decal Spawn
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other