feat: add quiet test output mode#61
Open
exo-mv wants to merge 7 commits into
Open
Conversation
Adds a `--quiet` flag (and `EXODUS_TEST_QUIET=1` env equivalent) that suppresses pass/skip lines and per-suite headers for passing suites, surfacing only failing suites plus the final summary. Works across the node:test reporter, CI `::group::` grouping, and the per-file bundle/ browser runner path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
sparten11740
approved these changes
Jun 24, 2026
sparten11740
left a comment
sparten11740
left a comment
Contributor
There was a problem hiding this comment.
utACK - some non-blocking comments
| setEnv('EXODUS_TEST_PLATFORM', options.binary === 'shermes' ? 'hermes' : options.binary) // e.g. 'hermes', 'node' | ||
| setEnv('EXODUS_TEST_TIMEOUT', options.testTimeout) | ||
| setEnv('EXODUS_TEST_DEVTOOLS', options.devtools ? '1' : '') | ||
| process.env.EXODUS_TEST_QUIET = options.quiet ? '1' : '' // internal signal for the reporter |
Contributor
There was a problem hiding this comment.
shouldn't this also be using setEnv to warn of conflicts in case the env var is already set?
Author
There was a problem hiding this comment.
it currently it silently ignores the EXODUS_TEST_QUIET env var. I don't think we need to support two modes (env var and cli flag) for every single thing, or even most things, but let's wait to hear from @ChALkeR
Comment on lines
+181
to
+184
| if (!quiet) { | ||
| const label = data.skip ? color('⏭ SKIP ', dim) : color('✔ PASS ', 'green') | ||
| if (!pskip(path)) print(`${label}${pathstr(path)}${formatSuffix(data)}`) | ||
| } |
Contributor
There was a problem hiding this comment.
I wonder if architecturally this could've been done in a more extensible way e.g. abstract this behind a reporter interface that receives the log output and internally decides whether to buffer, print right away, remove parts of the output, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--quietflag that only reports failing test suites plus the final summaryVerification
npm run lintFORCE_COLOR=1 npm testNote: plain
npm testis color-sensitive in this shell because vendor matcher assertions expect colored output;FORCE_COLOR=1 npm testpasses.