[WIDP] Properly replaces analytics completeness SQL query#78
Closed
idelcano wants to merge 1 commit into
Closed
Conversation
tokland
changed the title
tokland
reviewed
Mar 11, 2025
There was a problem hiding this comment.
I renamed the title to the standard format used in this repo.
Regarding the missing commit, there are different ways of finding the actual commit in the repo. One is this: git log --all --ancestry-path 82dc8c0..2.41 and search for the commit. Another: git blame FILE and search the commit.
The final commit is: 446a324. We can cherry-pick it.
| limit 1;"""; | ||
| replace(sql, Map.of("startDate", toLongDate(startDate), "endDate", toLongDate(endDate))); | ||
| limit 1;""", Map.of("startDate", toLongDate(startDate), | ||
| "endDate", toLongDate(endDate))); |
There was a problem hiding this comment.
Unformated code. Reference: https://github.com/dhis2/wow-backend/blob/master/guides/code_formatting.md#option-2-format-manually
Member
|
No longer needed as this is already included in 2.41.4 by official code from UiO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by https://app.clickup.com/t/86982wug3
Related: #77
Motivation: SQL for completeness analytics is wrong.
Fix (cherry pick): 446a324