[WIDP] feat: add SMS 2FA#90
Draft
MatiasArriola wants to merge 15 commits into
Draft
Conversation
(cherry picked from commit bf37f72)
(cherry picked from commit ea4d9e6)
make DeliveryFailures not count towards attempts
Implemented since we do not have a CI infrastructure similar to upstream. Allow pointing to a local folder that contains the custom app version we want to bundle in the .war file
- duplicated key conflict for Superuser role - urls [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://app.clickup.com/t/8699feudb
Implementation based on existing Email 2FA infrastructure.
TODO:
LoginResponseif the SMS delivery fails during auth?enforceVerifiedEmail