Conversation
- leaf blocks - sand - gravel - concrete powder
…ase_block_allow-are-unable-to-have-block-variants-generated' into 12-certain-blocks-with-the-tag-base_block_allow-are-unable-to-have-block-variants-generated
|
@codex review |
1 similar comment
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca7ead9225
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| GraphicsMode currentMode = MinecraftClient.getInstance().options.getGraphicsMode().getValue(); | ||
| if (lastGraphicsMode != currentMode) { | ||
| lastGraphicsMode = currentMode; | ||
| ReshapedClient.refreshVariantRenderLayers(); |
There was a problem hiding this comment.
ReshapedClient.refreshVariantRenderLayers() is now called from END_CLIENT_TICK after client.world is non-null, which means it remaps blocks via BlockRenderLayerMap.putBlock while a world is already loaded. Fabric’s BlockRenderLayerMap contract requires these mappings to be done before world load/rendering, so changing graphics mode in-game can trigger unsupported remaps that lead to renderer-dependent glitches or instability instead of a safe layer update.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
can you setup an issue about this?
1 participant
No description provided.