Skip to content

Harden extensions v2 review workflows - #160

Merged
admdly merged 4 commits into
mainfrom
codex/harden-extensions-v2
Jul 26, 2026
Merged

Harden extensions v2 review workflows#160
admdly merged 4 commits into
mainfrom
codex/harden-extensions-v2

Conversation

@admdly

@admdly admdly commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses all five findings from the pre-publication extensions v2 design and security review:

  • make submission approval atomic and bind it to the captured ownership epoch
  • bound submission payloads and pending backlog, reject duplicate pending targets globally, and add cursor pagination
  • guard developer self-updates against ownership-transfer races
  • bind developer approval to the exact content revision reviewed
  • move transfer bearer tokens from URL paths into JSON request bodies and shorten expiry to one hour

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
api f4a5b26 Commit Preview URL

Branch Preview URL
Jul 26 2026, 11:21 PM

@admdly admdly self-assigned this Jul 26, 2026
@admdly
admdly marked this pull request as ready for review July 26, 2026 22:51

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/db/migrations/0011_harden_review_workflows.sql Outdated
Comment thread src/services/extensions/v2/interfaces.ts Outdated
Comment thread src/services/extensions/v2/submissions-database.ts
Comment thread src/services/extensions/v2/developers-database.ts
@admdly
admdly marked this pull request as draft July 26, 2026 23:02
@admdly
admdly marked this pull request as ready for review July 26, 2026 23:04
@admdly
admdly marked this pull request as draft July 26, 2026 23:04
@admdly
admdly marked this pull request as ready for review July 26, 2026 23:05

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Requires human review: Database schema migration, payload size/backlog limits, token transfer changes, and ownership race guards introduce operational tradeoffs and security policy decisions requiring human sign-off.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/interfaces.ts
@admdly
admdly marked this pull request as draft July 26, 2026 23:13
@admdly
admdly marked this pull request as ready for review July 26, 2026 23:14

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread test/services/extensions/v2/index.test.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Requires human review: Includes a database migration and public contract changes (paginated responses, strict schemas, token body migration). Human review needed to verify correctness and backward compatibility.

Re-trigger cubic

@admdly
admdly marked this pull request as draft July 26, 2026 23:21
@admdly
admdly marked this pull request as ready for review July 26, 2026 23:21

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Requires human review: Adds a database migration and schema change (new columns, indexes, data updates) for atomic approvals and duplicate rejection. Requires human review for data model changes.

Re-trigger cubic

@admdly
admdly merged commit df6772e into main Jul 26, 2026
9 checks passed
@admdly
admdly deleted the codex/harden-extensions-v2 branch July 26, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant