Skip to content

Improve developer profile claim flow and add GitHub verification - #287

Merged
admdly merged 7 commits into
mainfrom
feat/github-org-claim
Jul 28, 2026
Merged

Improve developer profile claim flow and add GitHub verification#287
admdly merged 7 commits into
mainfrom
feat/github-org-claim

Conversation

@admdly

@admdly admdly commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Adds GitHub-based verification to developer profiles and claims, and improves the create/claim flow. Moderators see a “GitHub verified” badge, and users are only guided to claim when a taken ID belongs to an unclaimed profile.

  • New Features

    • Sync GitHub identity from auth on login and persist to users (github_login, github_orgs).
    • Auto-verify ownership when GitHub matches the developer ID (on create and on claim); expose github_org_verified and github_verification_note to moderators only; show a “GitHub verified” badge in developer and claim moderation lists.
    • When create fails because the ID exists on an unowned profile, show a link to claim it; detection uses the DEVELOPER_ID_TAKEN code and confirms the profile is unclaimed; add clearer helper text for the ID field.
  • Migration

    • Run 0005_add_github_fields.sql to add github_login and github_orgs to users.
    • Ensure the auth service requests the read:org scope so OIDC claims populate.

Written for commit 181d0d0. Summary will update on new commits.

admdly added 4 commits July 28, 2026 09:09
Creating a developer profile with an id that already belongs to an
unowned legacy profile (e.g. "fossbilling") failed with a dead-end
error. Surface a link to that profile's public page and the existing
claim flow instead.

Claude-Session: https://claude.ai/code/session_01QaaK546yMRs9xgyGrnu7Vx
@admdly admdly self-assigned this Jul 28, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 28, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
extensions 181d0d0 Commit Preview URL

Branch Preview URL
Jul 28 2026, 01:52 PM

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: Introduces a new verification feature with a database migration (new columns on users), modifies authentication sync from OIDC claims, and adds auto-verification logic. These changes involve security and operational tradeoffs that need human sign-off.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/pages/account/developer/index.astro Outdated
Comment thread src/types/index.ts
Comment thread src/pages/account/developer/index.astro Outdated
admdly added 2 commits July 28, 2026 14:43
- The "claim this profile instead" guidance now only shows when the
  conflicting id is actually unclaimed (checked via getDeveloperById).
  A duplicate id already owned by someone else has no working claim
  option, so pointing the user at it was a dead end.
- Detection now matches the api repo's dedicated DEVELOPER_ID_TAKEN
  error code instead of the human-readable message string, so a
  reworded message can't silently break it.
- PublicDeveloperProfile now excludes github_org_verified/
  github_verification_note, same as contact_email/content_revision —
  these are a moderator-only signal and were reachable by public
  /developer/[id] consumers even though the query never selects them.

Claude-Session: https://claude.ai/code/session_01QaaK546yMRs9xgyGrnu7Vx

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Requires human review: Includes a database migration (adding columns to users table) and introduces GitHub OIDC-based verification for developer profiles, which are operational and policy changes requiring human oversight.

Re-trigger cubic

@admdly
admdly merged commit 52183c8 into main Jul 28, 2026
9 checks passed
@admdly
admdly deleted the feat/github-org-claim branch July 28, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant