Rework the extension submission form's Publisher/License/select fields - #308
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
extensions | e8cfd7e | Commit Preview URL Branch Preview URL |
Aug 08 2026, 06:03 PM |
admdly
force-pushed
the
license-spdx-picker
branch
from
August 8, 2026 17:23
1c4617a to
c35ab98
Compare
Contributor
Author
|
@cubic review |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
admdly
force-pushed
the
license-spdx-picker
branch
from
August 8, 2026 17:46
c35ab98 to
013f7dc
Compare
Contributor
Author
|
@cubic review |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Several small UX passes on the "Submit an Extension" form (src/components/ExtensionForm.astro), plus one catalogue filter fix: - Publisher: replace the "Edit Developer Profile" text link (which was missing a space after the sentence) with an icon-only button, fixing the underlying cause too — the row was using `flex`+`gap` on a `<p>` mixing text and an inline element, which was quietly eating normal word-spacing across the whole sentence, not just before the link. - Extension ID is now suggested live from Name (slugified to the server's `[a-z0-9]+(-[a-z0-9]+)*` pattern) and reordered above it, same override-once-edited pattern used throughout; Name/ID/Type reordered so naming happens before the id is suggested. - Fixed two `<select>` fields (Type, Repository Host) missing `w-full`, and one on the homepage catalogue filter that had the wrong component class entirely (`input` instead of `select`, silently falling back to unstyled native rendering). - License: replaced the free-text License Name input with a basecoat-css combobox searching the full current SPDX license list (spdx-license-ids), grouped into "Popular Licenses" (a presentational shortlist only — every id still comes from the same package, nothing is excluded from search) and "All Licenses (A-Z)", plus an "Other / Proprietary" option that reveals a custom-name field. Picking a recognized license auto-suggests its canonical https://spdx.org/licenses/<id>.html as the License URL. Submits through the existing license_spdx_id hidden input; extension-form.ts resolves the final license.name/spdx_id server-side so it's correct without JS too. Needed adding `basecoat-css/combobox` to the behavior modules this app imports (src/layouts/Base.astro) — it was never loaded before, unlike tabs/toast. - Regenerated the extensions-v2 API client against the api repo's new license.spdx_id field (see the api repo's matching branch). Also adds .claude/launch.json so the `run` skill can start this app's dev server directly.
admdly
force-pushed
the
license-spdx-picker
branch
from
August 8, 2026 18:03
013f7dc to
e8cfd7e
Compare
Contributor
Author
|
@cubic reviw |
There was a problem hiding this comment.
No issues found across 12 files
Auto-approved: UX improvement to license field: SPDX combobox with custom option, adds missing name field, validated by tests including edge cases.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several small UX passes on the "Submit an Extension" form (
src/components/ExtensionForm.astro), plus one catalogue filter fix.