Skip to content

Reset canvas state when toggling between original and string-art previews #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Reset canvas state when toggling between original and string-art previews #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed07fdb
Initial plan
Copilot Jun 3, 2026
96203dd
fix: reset canvas state when toggling preview modes
Copilot Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions string-art-website/src/features/3RenderImage/components/StringArtCanvas/StringArtCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,15 @@ export const StringArtCanvas = forwardRef<HTMLCanvasElement, StringArtCanvasProp
const ctx = canvas.getContext('2d');
if (!ctx) return;

const resetCanvas = () => {
ctx.globalCompositeOperation = 'source-over';
ctx.clearRect(0, 0, width, height);
ctx.fillStyle = 'white';
ctx.fillRect(0, 0, width, height);
};

// Always clear the canvas at the start of a render
ctx.fillStyle = 'white';
ctx.fillRect(0, 0, width, height);
resetCanvas();

let isCancelled = false;

Expand All @@ -41,8 +47,7 @@ export const StringArtCanvas = forwardRef<HTMLCanvasElement, StringArtCanvasProp
if (isCancelled) return;

// Clear canvas again right before drawing to prevent race conditions
ctx.fillStyle = 'white';
ctx.fillRect(0, 0, width, height);
resetCanvas();

const scale = Math.min(width / img.width, height / img.height);
const scaledWidth = img.width * scale;
Expand Down