Skip to content

proxy: add support for request proxies#32

Open
xvaier wants to merge 1 commit into
mainfrom
xavier/add-support-for-proxies
Open

proxy: add support for request proxies#32
xvaier wants to merge 1 commit into
mainfrom
xavier/add-support-for-proxies

Conversation

@xvaier
Copy link
Copy Markdown

@xvaier xvaier commented May 14, 2026

No description provided.

@aviau
Copy link
Copy Markdown
Member

aviau commented May 14, 2026

Actually now that I read the code and that I see that we can pass a pre-configured Session object, I don't think this is worthy of changing the API of the client.

Just use the client like this:

session = FlareApiClient._create_session()
session.proxies.update(...)
client = FlareApiClient(session=session)

This avoids adding anything to the API surface and covers your (quite niche) use case. We should avoid adding new arguments for everything that Session already supports. The goal of having a session argument is exactly so that people can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants