Add applyTeacherTests() to SorterConfiguration (1.2.0) - #4
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The only noted issue is a minor README wording nit and does not block approval.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds teacher-test selection to SorterConfiguration, clarifies documentation, updates README terminology, and bumps the project to version 1.2.0.
Changes:
- Adds
applyTeacherTests()with a default value oftrue. - Documents that all sorter configurations are available to student tests.
- Updates README wording and dependency versions.
- Raises the required Java release to 25.
| File | Description |
|---|---|
src/main/java/sortingservice/SortingServiceFactory.java |
Clarifies sorter configuration stream documentation. |
src/main/java/sortingservice/SorterConfiguration.java |
Adds teacher-test selection support. |
README.md |
Updates exercise terminology; contains a minor duplicated-word nit. |
pom.xml |
Bumps project and parent versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
streamSorterConfigurations() now returns all configured sorters, so students can test every sorter in their own tests. The teacher tests filter on applyTeacherTests() instead. Bumps the version to 1.2.0.
Bonajo
force-pushed
the
feature/apply-teacher-tests
branch
from
September 23, 2026 17:34
fff5c69 to
93020e0
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SorterConfiguration.applyTeacherTests(): a new default method that returnstrue. The teacher tests use it to decide which configurations they test.streamSorterConfigurations()is now documented as returning all configured sorters. Students' own tests use this stream. Before, switching a sorter's teacher-test flag off also removed it from their own tests, so coverage dropped and the teacher tests never ran.SortingServiceFactory, and changed "appointment planner" to "sorting" in the README.informaticspom1.7 → 1.8.java.releasefrom 21 to 25, so projects using this API need JDK 25.After merging
Create GitHub release
v1.2.0. This triggersdeploy.yml, which publishes to Maven Central.