Bundled fixes: transaction history infinite scroll + mnemonic backup verify quiz (#705, #698) - #881
Merged
ONEONUORA merged 2 commits intoSep 1, 2026
Conversation
Guard against duplicate transaction rows when cursor pages overlap, e.g. when a new transaction arrives midway through a scroll session. Refs Fracverse#705
Add a verification step after the phrase is displayed that asks the user to select the exact word for positions 3, 7, and 11 from scrambled options. The wallet only unlocks once all selections match the generated recovery phrase. Refs Fracverse#698
|
@favvy994 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ONEONUORA
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled fixes for two Stellar Wave mobile app issues.
#705 — Implement infinite scroll pagination in transaction history feed
The transaction history feed already wired
FlatList'sonEndReachedto thecursor-based
loadMoreinuseTransactions. This PR hardens the infinitescroll by deduplicating overlapping cursor pages so transaction rows are
never duplicated when the backend returns already-seen items (e.g. when a new
transaction arrives midway through a scroll session).
onEndReachedcallback inFlatListto request the next cursor pagefrom the backend (already wired, now made robust against overlaps).
#698 — Build mnemonic backup verify quiz step during wallet generation
After the recovery phrase is displayed and the user confirms they saved it, a
verification quiz appears before wallet unlock:
choice), sourced from the phrase plus decoy words.
exact match with the generated phrase; an incorrect set triggers an
alert to review and retry.
Validation
node_modulesis not installed in this workspace, so fullnpm run lint/tsccould not be executed locally; changes are reviewed andvisually self-consistent with existing conventions.
Closes #705
Closes #698