Skip to content

Allow no items in the request - #50

Merged
ynnoig merged 4 commits into
FriendsOfCXML:mainfrom
profuel:patch-1
Apr 27, 2026
Merged

Allow no items in the request#50
ynnoig merged 4 commits into
FriendsOfCXML:mainfrom
profuel:patch-1

Conversation

@profuel

@profuel profuel commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

It seems that no items in the cart is a valid case for cXML flow as well.
Happens when customer wants to just get back to the eProcument platform.

@ynnoig ynnoig added the enhancement New feature or request label Apr 24, 2026
@ynnoig ynnoig self-assigned this Apr 24, 2026
@ynnoig

ynnoig commented Apr 24, 2026

Copy link
Copy Markdown
Member

@profuel Please check the CI Static validation and fix them. Thank u for your contribution!

@profuel

profuel commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

@ynnoig you don't seem to have tests to improve, right?

@profuel

profuel commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

@ynnoig I'm not sure how you trigger the CI, can you help me here?

@ynnoig

ynnoig commented Apr 24, 2026

Copy link
Copy Markdown
Member

@ynnoig I'm not sure how you trigger the CI, can you help me here?

@ynnoig I'm not sure how you trigger the CI, can you help me here?

We have an approval process to trigger the CI for new contributor. I made it.

@ynnoig

ynnoig commented Apr 24, 2026

Copy link
Copy Markdown
Member

Now it failed about 2 rector rules that are already in the new refactor branch done. We can ignore it at the moment in this PR. Thank u!

@profuel

profuel commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Thank you very much, @ynnoig !

@ynnoig
ynnoig merged commit 3ef6f3b into FriendsOfCXML:main Apr 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants