app-grid-button: decode the icon before the first draw - #2
Open
wayne-tbl wants to merge 1 commit into
Open
Conversation
gtk_image_set_from_gicon() defers the load to the first draw, and a GtkFlowBox recycles nothing, so the first scroll through the grid decoded an icon per row it revealed, on the main thread. Decode off the main thread instead and keep the result on the image as a scale-aware surface, refreshed when the theme or the scale changes. Warming GtkIconTheme does not help: every lookup returns a fresh GtkIconInfo, so nothing a previous load produced is reused. Signed-off-by: wayne <wayne@furilabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtk_image_set_from_gicon()defers the load to the first draw, and a GtkFlowBoxrecycles nothing, so the first scroll through the app grid decoded an icon per
row it revealed, on the main thread. This decodes off the main thread instead
and keeps the result on the image as a scale-aware surface, refreshed when the
theme or the scale changes.
Worth knowing before reviewing: warming
GtkIconThemewas tried first and buysnothing, because every lookup returns a fresh
GtkIconInfo, so nothing aprevious load produced is reused. That is why the fix holds the decoded surface
on the image rather than pre-warming a cache.
One commit, off
forky, independent of everything else in this series.Tested on an FLX1 (FuriOS, phosh 0.55).