Skip to content

Inconsistency Between Code and Comments in URQ Function #131

Description

@Satori31022809947

I've spotted an inconsistency in the URQ function within the codebase. The comments accurately describe the URQ, but the actual implementation seems to be off. It appears there's a discrepancy between the intended URQ and its current implementation in the code. Can we address this issue?

It appears there's a misplacement of parentheses in the following code snippet:

// (u * x) / ((u*(x-minValue[parameterName])-x+maxValue[parameterName])
const double x = entity.getRawParameterAt(parameter.second.getIndex());
const double u = attributeUValues[parameterName];
double den = (u * (x - minValue[parameterName]) - (x + maxValue[parameterName]));

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions