[Chore] Updated Git attributes - #313
Open
glektarssza wants to merge 2 commits into
Open
Conversation
Member
|
Addresses is not a proper keyword please see here https://help.github.com/articles/closing-issues-using-keywords/ |
| *.[wW][oO][fF][fF] binary | ||
| *.[wW][oO][fF][fF]2 binary | ||
|
|
||
| *.[pP][aA][tT][cC][hH] -text |
There was a problem hiding this comment.
Was this supposed to get removed?
Member
Author
There was a problem hiding this comment.
Yes it was as .patch files are normally text files. Why they were having the text Git attribute stripped from them is unclear and likely a mistake.
If there's a reason to keep this line I'm happy to add it back in.
|
Overall, this looks good. |
Member
Author
@PLASMAchicken fixed the PR description to use a proper keyword. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280. Also just generally cleaned up the file a bit.