-
Notifications
You must be signed in to change notification settings - Fork 123
review rules: the ruled checklist batch; preflight: 2x suite caps; docs: the hand-wired link set #3890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
review rules: the ruled checklist batch; preflight: 2x suite caps; docs: the hand-wired link set #3890
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # LAWS - ruling provenance (append-only; not a rule document) | ||
|
|
||
| - 2026-08-27 - `REVIEW.md` - Boris kept the broad codegen-version trigger against a proposal | ||
| to narrow it to cached artifacts: "i'd rather bump. sometimes hard to say if it changes | ||
| emission or not. and cache is not my concern." He also deleted the re-pin carve-out clause | ||
| outright rather than trimming it: "we are saving very little time. jited dll is not exactly | ||
| a lot of value... world won't end." Platform clause on the module-suite rule: "yes. its a | ||
| good rule." Routing line for the pinned emitter hash accepted with the small/ pin-rule | ||
| rebind ("sure."). | ||
|
|
||
| - 2026-08-27 - `REVIEW.md` - the `LLVM_JIT_EMITTER_HASH` routing line added earlier today | ||
| was removed with the pinned-value arm it routed (dragon duplicate finding; Boris: "okie"). | ||
| The `[tune]` tail of the codegen-version rule was re-mooded from an exemption to | ||
| trigger-narrowing (dragon REMOVE EXCEPTIONS; wording applied verbatim). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # LAWS - ruling provenance (append-only; not a rule document) | ||
|
|
||
| - 2026-08-27 - `REVIEW.md` - Boris adopted the green-by-skip rule ("yes.") and placed it | ||
| tests-cpp-wide rather than small/-only ("sounds good"). He kept the CMakeLists-owning | ||
| stray routing line and had big/'s rule unscoped so routed strays bind ("sounds good"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # LAWS - ruling provenance (append-only; not a rule document) | ||
|
|
||
| - 2026-08-27 - `REVIEW.md` - "under this folder" dropped from the ran-locally rule so a | ||
| CMakeLists-owning test routed here from tests-cpp/ binds; Boris: keep the routing and | ||
| unscope ("sounds good"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # LAWS - ruling provenance (append-only; not a rule document) | ||
|
|
||
| - 2026-08-27 - `REVIEW.md` - pin rule rebound from "loosens or deletes" to the two concrete | ||
| acts (widens/removes an assertion; updates a pinned value wherever it lives), with a | ||
| routing line added in modules/dasLLVM/REVIEW.md, after the folder walk failed to surface | ||
| the checklist for an out-of-folder re-pin in PR 3889; Boris: "sure." | ||
|
|
||
| - 2026-08-27 - `REVIEW.md` - the pinned-value arm added earlier today was removed on the | ||
| dragon's duplicate finding: the pin test CI-enforces that pairing both directions, and | ||
| Boris applied his own test-enforced-deletion logic ("okie" to the recommendation). The | ||
| rule keeps the widen/remove arm with the decidable wording. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.