feat: get floors endpoint#189
Merged
eric-kitagawa merged 6 commits intomainfrom Mar 19, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 0.92% 12.36% +11.44%
==========================================
Files 42 83 +41
Lines 1410 2636 +1226
Branches 0 24 +24
==========================================
+ Hits 13 326 +313
- Misses 1397 2305 +908
- Partials 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Dao-Ho
requested changes
Mar 19, 2026
Contributor
Dao-Ho
left a comment
There was a problem hiding this comment.
One small nit, otherwise looks great!
| return err | ||
| } | ||
|
|
||
| floors, err := h.repo.FindFloors(c.Context(), hotelID) |
Contributor
There was a problem hiding this comment.
One small nit but I think it's important to have a distinction between find floors (set of floors) vs find all floors
Suggested change
| floors, err := h.repo.FindFloors(c.Context(), hotelID) | |
| floors, err := h.repo.FindAllFloors(c.Context(), hotelID) |
spokonya
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added get floors endpoint