Skip to content

feat: get floors endpoint#189

Merged
eric-kitagawa merged 6 commits intomainfrom
eric/get-floors-rom
Mar 19, 2026
Merged

feat: get floors endpoint#189
eric-kitagawa merged 6 commits intomainfrom
eric/get-floors-rom

Conversation

@eric-kitagawa
Copy link
Copy Markdown
Contributor

Added get floors endpoint

  • Only returns distinct floor numbers
  • Filters by hotel_id

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
selfserve-web Ready Ready Preview, Comment Mar 18, 2026 1:31am

@eric-kitagawa eric-kitagawa marked this pull request as ready for review March 18, 2026 01:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 29.62963% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.36%. Comparing base (388c9a0) to head (14c5942).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/repository/rooms.go 0.00% 18 Missing ⚠️
backend/internal/service/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #189       +/-   ##
==========================================
+ Coverage   0.92%   12.36%   +11.44%     
==========================================
  Files         42       83       +41     
  Lines       1410     2636     +1226     
  Branches       0       24       +24     
==========================================
+ Hits          13      326      +313     
- Misses      1397     2305      +908     
- Partials       0        5        +5     
Flag Coverage Δ
backend 23.04% <29.62%> (?)
mobile 84.00% <ø> (?)
web 0.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/rooms.go 86.66% <100.00%> (ø)
backend/internal/service/server.go 0.00% <0.00%> (ø)
backend/internal/repository/rooms.go 0.00% <0.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-kitagawa eric-kitagawa self-assigned this Mar 18, 2026
@eric-kitagawa eric-kitagawa added feature Introduces a new and complete feature needs review labels Mar 18, 2026
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise looks great!

Comment thread backend/internal/handler/rooms.go Outdated
return err
}

floors, err := h.repo.FindFloors(c.Context(), hotelID)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but I think it's important to have a distinction between find floors (set of floors) vs find all floors

Suggested change
floors, err := h.repo.FindFloors(c.Context(), hotelID)
floors, err := h.repo.FindAllFloors(c.Context(), hotelID)

@eric-kitagawa eric-kitagawa requested a review from Dao-Ho March 19, 2026 17:21
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_he_the_goat?: yes ✅

@eric-kitagawa eric-kitagawa merged commit ee783a4 into main Mar 19, 2026
16 checks passed
@eric-kitagawa eric-kitagawa deleted the eric/get-floors-rom branch March 19, 2026 17:24
spokonya pushed a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Introduces a new and complete feature needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants