Skip to content

Swagger update#195

Merged
danctila merged 2 commits intomainfrom
danc/swagger-update
Mar 19, 2026
Merged

Swagger update#195
danctila merged 2 commits intomainfrom
danc/swagger-update

Conversation

@danctila
Copy link
Copy Markdown
Contributor

@danctila danctila commented Mar 19, 2026

Description

  • Adds bearer auth to swagger docs (needed since Clerk has been added)
  • Adjusted env samples for backend and backend/config
    • Includes NEW env variable APP_CORS_ORIGINS (ex http://localhost:3000)
    • Includes NEW env variable APP_HOST (ex localhost:8080)

@danctila danctila self-assigned this Mar 19, 2026
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added APP_HOST here, the APP_CORS_ORIGINS is pulled directly from os.Getenv

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.57%. Comparing base (c54d3b5) to head (453d220).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/service/server.go 0.00% 6 Missing ⚠️
backend/internal/handler/swagger.go 0.00% 3 Missing ⚠️
backend/cmd/server/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #195       +/-   ##
==========================================
+ Coverage   0.90%   12.57%   +11.66%     
==========================================
  Files         39       80       +41     
  Lines       1322     2521     +1199     
  Branches       0       24       +24     
==========================================
+ Hits          12      317      +305     
- Misses      1310     2199      +889     
- Partials       0        5        +5     
Flag Coverage Δ
backend 22.88% <0.00%> (?)
mobile 84.00% <ø> (?)
web 0.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/devs.go 84.61% <ø> (ø)
backend/internal/handler/guests.go 63.63% <ø> (ø)
backend/internal/handler/hello.go 100.00% <ø> (ø)
backend/internal/handler/hotels.go 95.83% <ø> (ø)
backend/internal/handler/requests.go 98.37% <ø> (ø)
backend/internal/handler/rooms.go 81.81% <ø> (ø)
backend/internal/handler/s3.go 0.00% <ø> (ø)
backend/internal/handler/users.go 91.30% <ø> (ø)
backend/cmd/server/main.go 0.00% <0.00%> (ø)
backend/internal/handler/swagger.go 0.00% <0.00%> (ø)
... and 1 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a nice to have - not fully necessary

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was needed for the new Clerk tokens passed through swagger since they are quite large

@danctila danctila marked this pull request as ready for review March 19, 2026 15:52
@danctila danctila requested a review from Dao-Ho March 19, 2026 15:52
@danctila danctila merged commit 94e828b into main Mar 19, 2026
18 checks passed
@danctila danctila deleted the danc/swagger-update branch March 19, 2026 15:54
spokonya pushed a commit that referenced this pull request Apr 1, 2026
* add bearer auth to swagger docs

* update env samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants