Skip to content

feat: mobile notifs first pass#350

Open
danctila wants to merge 16 commits intomainfrom
danc/mobile-notifs
Open

feat: mobile notifs first pass#350
danctila wants to merge 16 commits intomainfrom
danc/mobile-notifs

Conversation

@danctila
Copy link
Copy Markdown
Contributor

@danctila danctila commented Apr 15, 2026

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Screenshots/Recordings

CleanShot.2026-04-15.at.22.40.20.mp4
CleanShot.2026-04-14.at.21.32.57.mp4

@danctila danctila marked this pull request as ready for review April 15, 2026 01:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.19%. Comparing base (ce594ee) to head (e08ba17).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/repository/notifications.go 0.00% 19 Missing ⚠️
backend/internal/handler/notifications.go 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #350      +/-   ##
========================================
+ Coverage   3.12%   7.19%   +4.07%     
========================================
  Files        110     180      +70     
  Lines       6081   10056    +3975     
  Branches      19      29      +10     
========================================
+ Hits         190     724     +534     
- Misses      5890    9307    +3417     
- Partials       1      25      +24     
Flag Coverage Δ
backend 14.63% <7.69%> (?)
mobile 97.29% <ø> (?)
web 2.88% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/notifications.go 83.72% <28.57%> (ø)
backend/internal/repository/notifications.go 0.00% <0.00%> (ø)

... and 82 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danctila danctila self-assigned this Apr 15, 2026
@danctila danctila marked this pull request as draft April 15, 2026 15:17
@danctila danctila requested a review from Dao-Ho April 16, 2026 01:38
@danctila danctila marked this pull request as ready for review April 16, 2026 01:38
Dao-Ho
Dao-Ho previously approved these changes Apr 16, 2026
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit/ consideration

Comment thread clients/mobile/app/notifications.tsx Outdated
@danctila danctila requested a review from Dao-Ho April 16, 2026 02:41
@danctila danctila added the feature Introduces a new and complete feature label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Introduces a new and complete feature needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants