Figure.ternary: Support Frame's xaxis/yaxis/zaxis attributes to set axis settings for a/b/c axes by Chuan1937 · Pull Request #4517 · GenericMappingTools/pygmt

Chuan1937 · 2026-04-09T07:04:55Z

Add ternary frame

Update the test pygmt/tests/test_ternary.py to use the new implemented Frame and Axis parameter classes.

Fixes partly #4494

seisman · 2026-04-09T07:47:26Z

yvonnefroehlich · 2026-04-09T08:57:54Z

Actually I would split this into two PRs, one for the code changes for the ternary frame itself and one for updating the tests.

seisman · 2026-04-10T07:06:34Z

Actually I would split this into two PRs, one for the code changes for the ternary frame itself and one for updating the tests.

Actually we have to update the tests in this PR to ensure the code changes are correct.

…nto test_ternary

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman · 2026-04-17T03:54:19Z

    )
    return fig
+
+


Need to add the @pytest.mark.mpl_image_compare marker and add the baseline images.

Suggested change

@pytest.mark.mpl_image_compare

seisman · 2026-04-17T03:54:27Z

+        pen="thinnest",
+    )
+
+


Suggested change

@pytest.mark.mpl_image_compare

add ternary frame

8ab177e

Chuan1937 mentioned this pull request Apr 9, 2026

Migrate frame settings to the new Frame/Axis syntax across examples and docs #4494

Open

60 tasks

Chuan1937 requested a review from seisman April 9, 2026 07:10

Chuan1937 self-assigned this Apr 9, 2026

Chuan1937 added this to the 0.19.0 milestone Apr 9, 2026

Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc

7744978

Chuan1937 mentioned this pull request Apr 9, 2026

POC: DOC/Gallery example "Ternary diagram": Migrate frame settings to the new Frame/Axis syntax #4505

Draft

Merge branch 'main' into test_ternary

c9eb74d

Revert test_ternary.py changes to split into two PRs

1e49df0

Chuan1937 changed the title ~~Add ternary frame and DOC/Test "test_ternary": Migrate frame settings to the new Frame/Axis syntax~~ Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc Apr 10, 2026

Chuan1937 changed the title ~~Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc~~ Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc for ternary Apr 10, 2026

Chuan1937 added 2 commits April 10, 2026 14:51

Merge branch 'main' into test_ternary

c1056a4

fix mypy check

26a8c43

seisman reviewed Apr 10, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc for ternary

a186dde

seisman reviewed Apr 10, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Chuan1937 added 5 commits April 10, 2026 20:14

internal function

098ea9b

Merge branch 'main' into test_ternary

4732e16

Merge branch 'test_ternary' of github.com:GenericMappingTools/pygmt i…

077fcba

…nto test_ternary

private function

6924d9f

format check

a353399

seisman changed the title ~~Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc for ternary~~ Figure.ternary: Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc Apr 10, 2026

seisman reviewed Apr 13, 2026

View reviewed changes

Comment thread pygmt/tests/test_ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Chuan1937 added 2 commits April 15, 2026 14:50

use dataclass

9a98469

check

71584a0

seisman reviewed Apr 16, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Update pygmt/src/ternary.py

e01f5a5

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Chuan1937 and others added 5 commits April 16, 2026 18:32

Update pygmt/src/ternary.py

843a112

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Merge branch 'main' into test_ternary

4b1770b

fix check

43700a8

use alias

358679b

fix failure

3c53887

seisman reviewed Apr 16, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Chuan1937 and others added 2 commits April 16, 2026 21:10

Update pygmt/src/ternary.py

4abc67c

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

fix

9bdbb7e

seisman reviewed Apr 16, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py

seisman reviewed Apr 16, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

seisman added the enhancement Improving an existing feature label Apr 16, 2026

Chuan1937 and others added 3 commits April 17, 2026 09:46

Update pygmt/src/ternary.py

6015793

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

c956f54

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

461b408

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman changed the title ~~Figure.ternary: Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc~~ Figure.ternary: Support Frame's xaxis/yaxis/zaxis attributes to set axis settings for a/b/c axes Apr 17, 2026

seisman reviewed Apr 17, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

seisman reviewed Apr 17, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py

seisman added the needs review This PR has higher priority and needs review. label Apr 17, 2026

Chuan1937 and others added 8 commits April 17, 2026 11:18

Update pygmt/src/ternary.py

7d96092

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

cce2532

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

8834278

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

3372921

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

c131e37

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

eb0288a

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

c06fa85

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/ternary.py

4d52917

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman reviewed Apr 17, 2026

View reviewed changes

Comment thread pygmt/src/ternary.py Outdated

Comment thread pygmt/src/ternary.py

Comment thread pygmt/tests/test_ternary.py

add format,docstring,test

7b29bdd

seisman reviewed Apr 17, 2026

View reviewed changes

Conversation

Chuan1937 commented Apr 9, 2026

Uh oh!

seisman commented Apr 9, 2026

Uh oh!

yvonnefroehlich commented Apr 9, 2026

Uh oh!

Uh oh!

seisman commented Apr 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seisman Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

seisman Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants