feat(tui): add memory and session deletion flows#471
Closed
1563245379 wants to merge 13 commits into
Closed
Conversation
Collaborator
|
Thanks for the work here, but I am closing this PR because it is too broad for #94 and overlaps with the smaller session-delete PR in #444. This changes memory deletion, restore, purge, recycle-bin behavior, MCP semantics, docs, and TUI behavior in one 2,360-line PR. If we want recycle-bin semantics later, it needs its own approved issue and a chained PR plan with one reviewable slice at a time. For now, #444 covers the session deletion scope we actually want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #94
PR Type
type:bug- Bug fixtype:feature- New featuretype:docs- Documentation onlytype:refactor- Code refactoring (no behavior change)type:chore- Maintenance, dependencies, toolingtype:breaking-change- Breaking changeSummary
mem_deletesoft-delete only and updates docs to match recycle-bin behavior.Changes
internal/store/store.gointernal/tui/model.gointernal/tui/update.gointernal/tui/view.gointernal/mcp/mcp.gomem_delete; deletes are soft-only.internal/*/*_test.goREADME.md,DOCS.md,docs/ARCHITECTURE.mdTest Plan
go test ./...go test -tags e2e ./internal/server/...Local checks run:
go test ./internal/store ./internal/tui ./internal/mcp -count=1internal/tuipassed.internal/storefailed on Windows temp DB cleanup withThe process cannot access the file because it is being used by another process.go test ./internal/mcp -count=1eval expected dir: Access is denied.for current-working-directory symlink evaluation tests.go test ./internal/mcp -count=1 -run TestSessionStartWithoutDirectoryUsesCurrentWorkingDirectoryoutside the Codex filesystem sandbox passed.go test ./internal/mcp -count=1 -run TestSessionStartWithWhitespaceDirectoryUsesCurrentWorkingDirectoryoutside the Codex filesystem sandbox passed.git diff --check main..HEADpassed.Automated Checks
These run automatically and all must pass before merge:
Closes #N/Fixes #N/Resolves #Nstatus:approvedlabeltype:*labelgo test ./...passesgo test -tags e2e ./internal/server/...passesContributor Checklist
Closes #N)type:*label to this PRgo test ./...go test -tags e2e ./internal/server/...Co-Authored-Bytrailers in commitsNotes for Reviewers
This PR was opened from a fork because the authenticated account cannot push directly to
Gentleman-Programming/engram. The targeted local test command has known Windows/Codex environment failures documented above; CI should provide the authoritative clean environment signal.