Skip to content

feat: add error handler for internal use#209

Merged
junghao merged 1 commit into
mainfrom
error-handler
Jun 16, 2026
Merged

feat: add error handler for internal use#209
junghao merged 1 commit into
mainfrom
error-handler

Conversation

@bpeng

@bpeng bpeng commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

User story: As a internal user I want to see the error message on server side when a submision failed on client side (e.g. nema-mar-portal)

Changes proposed in this pull request:

  • Add TextInternalError

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@bpeng bpeng requested a review from junghao June 15, 2026 21:25

@junghao junghao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@junghao junghao merged commit 0ff6244 into main Jun 16, 2026
8 checks passed
@junghao junghao deleted the error-handler branch June 16, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants