⚡ Optimize Dynamic Data Execution in Agent System Prompt - #106
Conversation
Modified `injectSystemPrompt` in `internal/ai/agent/logic.go` to execute `DynamicData` shell commands concurrently using goroutines. Previously, commands were executed synchronously, causing a bottleneck when multiple commands were defined in the configuration. The output is now captured in a pre-allocated slice to preserve ordering before appending it to the prompt. Co-authored-by: Gerifield <195914+Gerifield@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…-7841214127296637119 ⚡ Optimize Dynamic Data Execution in Agent System Prompt
1 participant
💡 What: The
injectSystemPromptfunction was refactored to retrieve dynamic data (external commands) concurrently via goroutines.🎯 Why: Previously, the
contextConfig.DynamicDataexecution happened synchronously within a loop. If a configuration specifies 3 shell commands that take ~100ms each, it blocked prompt generation for ~300ms. Running them concurrently improves latency, allowing all commands to execute within the duration of the longest-running single command.📊 Measured Improvement: In a micro-benchmark using three commands that each sleep for 100ms, execution time improved from ~312ms per operation (serial execution) to ~103ms per operation (parallel execution). The outputs remain correctly ordered as they appear in the configuration.
PR created automatically by Jules for task 7841214127296637119 started by @Gerifield