Implemented Firefox Driver, Updated Tests#69
Merged
Conversation
this might be due to the chrome driver and request refactoring to support both firefox and chrome
…tion Currently busy with figuring out why firefox tests aren't passing. It has something to do with how the firefox options are encoded and sent, specifically the arguments and possibly the profile top-level parameter.
…ment options initiation issues Next todo: ideally do not re-write all chrome tests, run each test suite twice but one with chrome and one with firefox.
…oth drivers, all tests pass as expected
vimscientist69
changed the title
AdonisCodes
approved these changes
Jul 9, 2026
… fixing docker-compose service names
…isibility, and add deinit cleanup to integration tests
…nit cleanup to integration tests
hopefully fix tests test action not passing in gh actions
vimscientist69
force-pushed
the
feat/firefox-driver
branch
from
1364b49 to
39795a4
Compare
vimscientist69
force-pushed
the
feat/firefox-driver
branch
from
fc91cf2 to
a4f7836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Implementing Firefox driver as further development and also to support Firefox in HeliumSwift.
Tech Details List
Tasks:
Testing
Steps:
TESTING-QAOutput:
Testing QA