Skip to content

data: recover 846 GSMArena budget phones via SoC-matcher fix#101

Merged
Seungpyo1007 merged 5 commits into
mainfrom
data/import-staging
Jul 7, 2026
Merged

data: recover 846 GSMArena budget phones via SoC-matcher fix#101
Seungpyo1007 merged 5 commits into
mainfrom
data/import-staging

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

What & why

Follow-up to PR #98. While importing cigarplug/scrape-gsma I found a bug in my SoC-matcher's die-number extraction (it stripped hyphens, breaking the \b word boundary so mediatek-mt6582 never matched the chipset Mediatek MT6582). Fixing it recovers 846 budget/mid-range phones — mostly MediaTek MT6xxx devices — that link to already-existing SoCs (no new SoC records needed).

  • Added: 846 smartphones (BLU, Allview, Verykool, Lenovo, Micromax, Alcatel, ZTE, Panasonic, Gionee, and other budget brands)
  • Modified/Deleted: 0
  • All verified: false, integer ram_gb, valid soc FK to the existing catalog.

Commits (each Refs #1): 4 brand-group smartphone commits + surgical dump refresh.

Closes #1

Source

GSMArena via cigarplug/scrape-gsma, *-scrapegsma-<row> slugs; rows previously skipped only because the die-token matcher missed their SoC.

Dump

Regenerated via TechEngine app.dump at pinned submodule c0928f9 (scoring v2.0.0). Only the 846 new records' detail+score files, the smartphones index (92,497→93,343) and the manifest are committed — no churn on unchanged records.

Checklist

  • python -m app.validate — ✅ passed
  • python TechEngine/integrity_check.py data --strict — ✅ no hard anomalies
  • git diff --check — ✅ clean
  • Correct paths, kebab-case unique slugs, source_urls present

… budget brands

Budget/emerging-market phones recovered from cigarplug/scrape-gsma
after fixing SoC die-number matching (MediaTek MT6xxx family now links
to the existing SoC catalog). verified:false.

Refs #1
… ZTE, Panasonic

More budget/mid phones recovered from cigarplug/scrape-gsma via the
SoC-matcher fix. SoC-linked, verified:false.

Refs #1
…ko, Lava and others

Recovered cigarplug/scrape-gsma phones across Gionee, Acer, Oppo, LG,
Wiko, Lava, Vivo, Tecno. SoC-linked, verified:false.

Refs #1
Remaining cigarplug/scrape-gsma phones unlocked by the SoC die-match
fix (Karbonn, Intex, Spice, Celkon, Maxwest and other budget brands).
SoC-linked, verified:false.

Refs #1
Add the 846 recovered GSMArena (cigarplug/scrape-gsma) smartphone
records to the static v1 dump — detail + score — and bump the
smartphones index count (92497->93343) and manifest. Regenerated via
TechEngine app.dump at pinned submodule c0928f9 (scoring v2.0.0);
only the new records and affected index are committed.

Refs #1
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 Review — PASS

Check Command Result
Schema/self-check python -m app.validate ✅ passed (full dataset)
Integrity gate python TechEngine/integrity_check.py data --strict ✅ no hard anomalies
Whitespace git diff --check origin/main..HEAD ✅ none
Engine dump app.dump @ c0928f9 ✅ 105,671 records, no serializer errors

Data-change summary

  • Added: 846 smartphones · Modified/Deleted: 0
  • All verified:false, integer ram_gb, valid soc FK (all 846 verified against the SoC catalog: 0 invalid).
  • Root cause fixed: SoC die-token matcher stripped hyphens → \b boundary broke → mediatek-mt6582 never matched Mediatek MT6582. Now die numbers (MT6xxx, SM8xxx, MSM8xxx, SDM6xx) extract correctly.

Example records

  • data/smartphone/acer/2012/liquid-gallant-duo/acer-liquid-gallant-duo-scrapegsma-1759.json (soc mediatek-mt6575)
  • BLU/Allview/Verykool budget devices on MediaTek MT6580/MT6582/MT6737.

Site build

  • No site/src changes. Surgical dump refresh (846 new records + smartphones index + manifest only).

@Seungpyo1007

Copy link
Copy Markdown
Member Author

📊 Dataset stats (post-merge projection)

Metric Count
Total records 105,671
verified: true 10,028
verified: false 95,637
missing verified 6
Verified ratio 9.49%

Warning

Verified ratio 9.49% — expected for the bulk-import campaign; promotion happens later via TechEngine verify-network. The 6 missing-verified records pre-date this PR.

Session running total (cigarplug/scrape-gsma fully mined): PR #97 (373) + PR #98 (2,498) + this (846) = 3,717 net-new records. cigarplug is now exhausted; further phone growth needs new datasets or a new category (see #1).

@Seungpyo1007 Seungpyo1007 merged commit 2ab111b into main Jul 7, 2026
5 checks passed
@Seungpyo1007 Seungpyo1007 moved this from In Progress to Done in TechAPI-Project Jul 7, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

No records scored.

Full-dataset baseline

105671 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 10029
    "Yellow" : 93177
    "Red" : 2465
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 189 10 179 0 5.3%
soc 🟩🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥🟥 2104 123 680 1301 5.8%
smartphone 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93343 8453 83770 1120 9.1%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 174 3253 28 5.0%
watch 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 433 11 412 10 2.5%
pda 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 140 27 107 6 19.3%
gpu 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 2030 245 1785 0 12.1%
cpu 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨 3977 986 2991 0 24.8%
All 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 105671 10029 93177 2465 9.5%

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 10 179 0 189 5.3%
soc 2104 123 1981 0 2104 5.8%
smartphone 93343 8453 84890 0 93343 9.1%
tablet 3455 174 3281 0 3455 5.0%
watch 433 11 422 0 433 2.5%
pda 140 27 113 0 140 19.3%
gpu 2030 244 1786 0 2030 12.0%
cpu 3977 986 2991 0 3977 24.8%
all 105671 10028 95643 0 105671 9.5%

Warning

Tracked verified coverage is below 50% for watch 2.5% (11/433), tablet 5.0% (174/3455), brand 5.3% (10/189), soc 5.8% (123/2104), smartphone 9.1% (8453/93343), all 9.5% (10028/105671), gpu 12.0% (244/2030), pda 19.3% (27/140), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants