Skip to content

data(laptop): import Ammok laptops — 965 more (laptops 970->1935)#103

Merged
Seungpyo1007 merged 4 commits into
mainfrom
data/import-staging
Jul 8, 2026
Merged

data(laptop): import Ammok laptops — 965 more (laptops 970->1935)#103
Seungpyo1007 merged 4 commits into
mainfrom
data/import-staging

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

What & why

Second laptop dataset, extending the laptop category (added in PR #102) with 965 more laptops from Ammok/laptop_price_prediction (Hugging Face). These are mostly 2013–2018 machines — they complement the current-gen abhinavflac set rather than duplicate it (different eras, minimal overlap), and add brands the first set lacked (Toshiba, Razer, Xiaomi).

  • Added: 965 laptops (Dell 232, Lenovo 226, HP 179, Asus 122, Acer 83, Toshiba 39, MSI 34, Apple 17, and others)
  • All verified: false, integer ram_gb, weight_g from the source, brand FK required, cpu/gpu optional FK.
  • MSRP omitted — the source price column has an ambiguous currency/scale, so no price is injected rather than guessing.

Commits (each Refs #1): 3 brand-group data commits + surgical dump refresh.

Closes #1

Source

Ammok/laptop_price_prediction (HF). release_date year derived from the CPU generation (placeholder YYYY-01-01, source lacks dates); variant.source_row cites the CSV row.

Dump

Regenerated via TechEngine app.dump at submodule pin d1c3b0b. Laptops are unscored — only the new records + v1/laptops/index.json + manifest (laptops 970→1935) are committed; no churn on unchanged records.

Checklist

  • python -m app.validate — ✅ passed (full dataset)
  • python TechEngine/integrity_check.py data --strict — ✅ no hard anomalies
  • git diff --check — ✅ clean
  • Correct paths, kebab-case unique slugs (-ammok-<row> suffix, 0 collisions with abhinavflac), source_urls present

Second laptop dataset (Ammok/laptop_price_prediction, HF) — older
2013-2018 laptops complementing the abhinavflac current-gen set.
Dell and Lenovo lines with weight, RAM, storage, display, cpu/gpu
names. verified:false; MSRP omitted (ambiguous source currency).

Refs #1
More Ammok/laptop_price_prediction laptops (HP, Asus, Acer).
verified:false.

Refs #1
…ands

Remaining Ammok/laptop_price_prediction laptops (Toshiba, MSI, Apple,
Samsung, Microsoft, Razer, Xiaomi). verified:false.

Refs #1
Add the 965 Ammok laptop records to the static v1 dump (laptops
970->1935) and bump the manifest. Regenerated via TechEngine app.dump
at submodule pin d1c3b0b; only the new records + affected index +
manifest are committed.

Refs #1
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 Review — PASS

Check Command Result
Schema/self-check python -m app.validate ✅ passed (full dataset)
Integrity gate python TechEngine/integrity_check.py data --strict ✅ no hard anomalies
Whitespace git diff --check origin/main..HEAD ✅ none
Engine dump app.dump @ d1c3b0b ✅ 107,606 records incl. laptops:1935

Data-change summary

  • Added: 965 laptops (Ammok) · Modified/Deleted: 0
  • All verified:false; older 2013–2018 machines complementing the current-gen abhinavflac set. Brands added: Toshiba, Razer, Xiaomi. 0 slug collisions (-ammok- suffix).
  • MSRP omitted (ambiguous source currency) — no guessed prices.

Example records

  • data/laptop/acer/2013/acer-chromebook-14/acer-chromebook-14-ammok-691.json (Celeron 3855U, 4GB, 1.45kg)
  • Dell/Lenovo/HP 2016–2018 notebooks with weight, storage, cpu/gpu names.

Site build

  • No site/src changes. Surgical dump refresh — laptops 970→1935 + manifest only.

@Seungpyo1007

Copy link
Copy Markdown
Member Author

📊 Dataset stats (post-merge projection)

Metric Count
Total records 107,606
verified: true 10,028
verified: false 97,572
missing verified 6
Verified ratio 9.32%

laptops now 1,935 (abhinavflac 970 + Ammok 965) across 9 categories. Public laptop datasets are ~1k rows each; the two big ones are now imported, so laptops are near the public-data ceiling.

@Seungpyo1007 Seungpyo1007 merged commit 48971d3 into main Jul 8, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jul 8, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

No records scored.

Full-dataset baseline

105671 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 10029
    "Yellow" : 93177
    "Red" : 2465
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 189 10 179 0 5.3%
soc 🟩🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥🟥 2104 123 680 1301 5.8%
smartphone 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93343 8453 83770 1120 9.1%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 174 3253 28 5.0%
watch 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 433 11 412 10 2.5%
pda 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 140 27 107 6 19.3%
gpu 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 2030 245 1785 0 12.1%
cpu 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨 3977 986 2991 0 24.8%
All 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 105671 10029 93177 2465 9.5%

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 10 179 0 189 5.3%
soc 2104 123 1981 0 2104 5.8%
smartphone 93343 8453 84890 0 93343 9.1%
tablet 3455 174 3281 0 3455 5.0%
watch 433 11 422 0 433 2.5%
pda 140 27 113 0 140 19.3%
gpu 2030 244 1786 0 2030 12.0%
cpu 3977 986 2991 0 3977 24.8%
all 105671 10028 95643 0 105671 9.5%

Warning

Tracked verified coverage is below 50% for watch 2.5% (11/433), tablet 5.0% (174/3455), brand 5.3% (10/189), soc 5.8% (123/2104), smartphone 9.1% (8453/93343), all 9.5% (10028/105671), gpu 12.0% (244/2030), pda 19.3% (27/140), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants