Skip to content

data(laptop): link cpu/gpu to the component catalog (1287 CPU + 509 GPU)#104

Merged
Seungpyo1007 merged 2 commits into
mainfrom
data/import-staging
Jul 8, 2026
Merged

data(laptop): link cpu/gpu to the component catalog (1287 CPU + 509 GPU)#104
Seungpyo1007 merged 2 commits into
mainfrom
data/import-staging

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

What & why

Quality pass on the laptop category: resolve each laptop's cpu_name/gpu_name string to an existing CPU/GPU record and set the optional cpu/gpu foreign keys. Laptop detail pages now link to the component catalog (e.g. a laptop → its Core i7-6700HQ and RTX 1060).

  • CPU links: 1,287 · GPU links (dedicated only): 509 · across 1,467 of 1,935 laptops.
  • Matching is exact on the model code (7200U, 13420H, RTX 3050, GTX 1650) with a family cross-check (i5/i7/ryzen-5) — no fuzzy guessing. Integrated GPUs (Intel HD/UHD/Iris) and chips not in the catalog stay name-only. Raw cpu_name/gpu_name are preserved.
  • No new records; 1,467 laptops modified + their dump details refreshed.

Commits (each Refs #1): the FK-linking data commit + a surgical laptop-dump refresh.

Closes #1

Checklist

  • python -m app.validate — ✅ passed (all cpu/gpu FKs resolve to real records)
  • git diff --check — ✅ clean
  • Only laptops modified; dump limited to the 1,467 affected detail files

Resolve laptop cpu_name/gpu_name strings to existing CPU/GPU records
and set the optional `cpu`/`gpu` FKs (1287 CPU + 509 GPU links across
1467 laptops). Matching is exact on the model code (e.g. 7200U, RTX
3050) with a family cross-check; integrated GPUs and unmatched chips
stay name-only. Raw cpu_name/gpu_name are kept.

Refs #1
Update the 1467 laptop detail files that gained a cpu/gpu embed after
linking cpu_name/gpu_name to the component catalog. Regenerated via
app.dump @ d1c3b0b; only the affected laptop details are committed.

Refs #1
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 Review — PASS

Check Result
python -m app.validate ✅ passed (all 1,796 new cpu/gpu FKs resolve to real records)
git diff --check ✅ clean

Change: 1,287 CPU + 509 GPU foreign keys added across 1,467 laptops (of 1,935). Exact model-code match (7200U, RTX 3050) + family cross-check; integrated GPUs and catalog-missing chips stay name-only. No new records. Dump limited to the 1,467 affected laptop detail files.

@Seungpyo1007 Seungpyo1007 merged commit 8bba834 into main Jul 8, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jul 8, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

No records scored.

Full-dataset baseline

105671 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 10029
    "Yellow" : 93177
    "Red" : 2465
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 189 10 179 0 5.3%
soc 🟩🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥🟥 2104 123 680 1301 5.8%
smartphone 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93343 8453 83770 1120 9.1%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 174 3253 28 5.0%
watch 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 433 11 412 10 2.5%
pda 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 140 27 107 6 19.3%
gpu 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 2030 245 1785 0 12.1%
cpu 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨 3977 986 2991 0 24.8%
All 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 105671 10029 93177 2465 9.5%

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 10 179 0 189 5.3%
soc 2104 123 1981 0 2104 5.8%
smartphone 93343 8453 84890 0 93343 9.1%
tablet 3455 174 3281 0 3455 5.0%
watch 433 11 422 0 433 2.5%
pda 140 27 113 0 140 19.3%
gpu 2030 244 1786 0 2030 12.0%
cpu 3977 986 2991 0 3977 24.8%
all 105671 10028 95643 0 105671 9.5%

Warning

Tracked verified coverage is below 50% for watch 2.5% (11/433), tablet 5.0% (174/3455), brand 5.3% (10/189), soc 5.8% (123/2104), smartphone 9.1% (8453/93343), all 9.5% (10028/105671), gpu 12.0% (244/2030), pda 19.3% (27/140), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants