Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
31 changes: 31 additions & 0 deletions app/validate.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@
"verified",
}

MONITOR_REQUIRED = {
"slug",
"name",
"brand",
"release_date",
"size_inch",
"resolution",
"source_urls",
"verified",
}

DATE_RE = re.compile(r"^\d{4}-\d{2}-\d{2}$")


Expand Down Expand Up @@ -217,6 +228,7 @@ def validate() -> list[str]:
gpus = _load("gpu")
cpus = _load("cpu")
laptops = _load("laptop")
monitors = _load("monitor")

brand_slugs = {rec["slug"] for _, rec in brands if "slug" in rec}
soc_slugs = {rec["slug"] for _, rec in socs if "slug" in rec}
Expand All @@ -233,6 +245,7 @@ def validate() -> list[str]:
("gpu", gpus),
("cpu", cpus),
("laptop", laptops),
("monitor", monitors),
):
_check_unique_slugs(category, records, errors)

Expand Down Expand Up @@ -366,6 +379,24 @@ def validate() -> list[str]:
errors.append(f"{fname}: gpu '{rec.get('gpu')}' not a known GPU")
_check_variant_path(fname, rec, "laptop", errors, allow_flat=True)

for fname, rec in monitors:
_check_required(fname, rec, MONITOR_REQUIRED, errors)
_check_source_urls(fname, rec, errors)
_check_slug(fname, rec.get("slug"), errors)
if "release_date" in rec:
_check_date(fname, rec["release_date"], errors)
_check_range(fname, "size_inch", rec.get("size_inch"), 5, 120, errors)
_check_range(fname, "refresh_hz", rec.get("refresh_hz"), 24, 1000, errors)
if rec.get("ppi") is not None:
_check_range(fname, "ppi", rec.get("ppi"), 20, 1000, errors)
if rec.get("rating") is not None:
_check_range(fname, "rating", rec.get("rating"), 0, 5, errors)
if "msrp_usd" in rec:
_check_range(fname, "msrp_usd", rec["msrp_usd"], 10, 50000, errors)
if rec.get("brand") not in brand_slugs:
errors.append(f"{fname}: brand '{rec.get('brand')}' not a known brand")
_check_variant_path(fname, rec, "monitor", errors, allow_flat=True)

return errors


Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-acer-nitro-monitor-amazonmon-636",
"base_model_slug": "acer-acer-nitro-monitor",
"name": "acer Nitro KG1-23.8\" Monitor FullHD 1920x1080 100Hz IPS 1ms 250Nit HDMI VGA (Renewed)",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 23.8,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"panel_type": "IPS",
"msrp_usd": 300,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 636
}
}
20 changes: 20 additions & 0 deletions data/monitor/acer/2023/acer-cb241y/acer-cb241y-amazonmon-603.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"slug": "acer-cb241y-amazonmon-603",
"base_model_slug": "acer-cb241y",
"name": "acer CB241Y Full HD LCD Monitor - 16:9 - Black",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 23.8,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"msrp_usd": 99,
"rating": 4.0,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 603
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-102.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-102",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 102
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-104.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-104",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 104
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-14.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-14",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 14
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-153.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-153",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 153
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-163.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-163",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 163
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-178.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-178",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 178
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-191.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-191",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 191
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-193.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-193",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 193
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-208.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-208",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 208
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-223.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-223",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 223
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-226.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-226",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 226
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-251.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-251",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 251
}
}
21 changes: 21 additions & 0 deletions data/monitor/acer/2023/acer-cb272/acer-cb272-amazonmon-260.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"slug": "acer-cb272-amazonmon-260",
"base_model_slug": "acer-cb272",
"name": "Acer CB272 Ebmiprx 27\" FHD 1920 x 1080 Zero Frame Home Office Monitor | AMD FreeSync | 1ms VRB | 100Hz | 99% sRGB | Heig",
"brand": "acer",
"release_date": "2023-01-01",
"size_inch": 27.0,
"resolution": "1920x1080",
"verified": false,
"source_urls": [
"https://www.kaggle.com/datasets/durjoychandrapaul/amazon-products-sales-monitor-dataset"
],
"aspect_ratio": "16:9",
"refresh_hz": 100,
"msrp_usd": 130,
"rating": 4.6,
"variant": {
"source_dataset": "amazon-monitor-durjoychandrapaul",
"source_row": 260
}
}
Loading
Loading