feat(game): stream validation for game metadata#119
Closed
Seungpyo1007 wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Superseded by #120 because GitHub did not refresh this PR's head SHA after the follow-up validation fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Promotes games to a first-class validated data type without changing TechEngine.
verified, rating/playtime counts, collection fields, ESRB values, image URLs, slug uniqueness, and deterministic shard paths;python -m app.validate --category game, which walks the million-record game dataset without retaining JSON records in memory;Source
Not applicable: this is validator and repository-structure work. The fields are aligned with the existing
TechEngineGame model and response schema; no engine code or submodule pointer is changed.Checklist
python -m unittest tests.test_game_validation -vpasses locallypython -m app.validate(all categories) is intentionally deferred to CI because this working copy uses sparse checkoutdata/game/<slug[:2]>/<slug>.json