feat(game): stream validation for game metadata#121
Open
Seungpyo1007 wants to merge 9 commits into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Makes game metadata a first-class validated dataset while keeping the million-record import and its CI practical.
python -m app.validateandpython -m app.validate --category game, rather than retaining record JSON in memory;data/**changes and main pushes; validator-only PRs run focused unit tests without checking out the million-record dataset; andSource
Not applicable: validator and repository-structure work aligned with the existing TechEngine Game model. No TechEngine code or submodule pointer changes.
Checklist
_load(game)lagame shard passes streaming validation (1.705s, 2.03MiB peak)data/**PRs and main pushesassume-unchangedandskip-worktree