Skip to content

chore: fix stale validator references (scripts.validate → app.validate)#126

Merged
Seungpyo1007 merged 1 commit into
mainfrom
chore/doc-fixups
Jul 14, 2026
Merged

chore: fix stale validator references (scripts.validate → app.validate)#126
Seungpyo1007 merged 1 commit into
mainfrom
chore/doc-fixups

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

What

Two tiny doc/config corrections — no code behavior change, no data change (so no dump refresh needed).

  • app/validate.py docstring: python -m scripts.validatepython -m app.validate. There is no scripts/ module; the validator lives at app/validate.py, matching the README and the validate-data CI workflow.
  • .gitignore: removed a stale note referencing a non-existent data/_staging/ directory.

Why

Leftover references from an old module layout were misleading. Surfaced during a repo-wide cleanup pass.

Refs #1

- app/validate.py docstring: `python -m scripts.validate` -> `python -m app.validate`
  (no `scripts/` module exists; validator lives at app/validate.py, matching README + CI)
- .gitignore: drop stale note about non-existent `data/_staging/` directory

Refs #1
@github-actions github-actions Bot added app Validator or application code changes enhancement New feature or request labels Jul 14, 2026
@Seungpyo1007 Seungpyo1007 added the documentation Improvements or additions to documentation label Jul 14, 2026
@Seungpyo1007 Seungpyo1007 moved this from Todo to In Progress in TechAPI-Project Jul 14, 2026
@Seungpyo1007 Seungpyo1007 merged commit 679e487 into main Jul 14, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jul 14, 2026
@Seungpyo1007 Seungpyo1007 deleted the chore/doc-fixups branch July 14, 2026 09:54
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 207 10 197 0 207 4.8%
soc 2104 123 1981 0 2104 5.8%
smartphone 93396 8453 84943 0 93396 9.1%
tablet 3455 174 3281 0 3455 5.0%
watch 433 11 422 0 433 2.5%
pda 140 27 113 0 140 19.3%
gpu 2030 244 1786 0 2030 12.0%
cpu 3977 986 2991 0 3977 24.8%
all 105742 10028 95714 0 105742 9.5%

Warning

Tracked verified coverage is below 50% for watch 2.5% (11/433), brand 4.8% (10/207), tablet 5.0% (174/3455), soc 5.8% (123/2104), smartphone 9.1% (8453/93396), all 9.5% (10028/105742), gpu 12.0% (244/2030), pda 19.3% (27/140), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Validator or application code changes documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants